Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nodejs] Enable tests for automated login events v3 #3666

Open
wants to merge 14 commits into
base: malvarez/appsec-login-events-v3
Choose a base branch
from
Open

[nodejs] Enable tests for automated login events v3 #3666

wants to merge 14 commits into from
+8 −6

Conversation

simon-id
Copy link
Member

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@simon-id simon-id mentioned this pull request Dec 12, 2024
Merged
@simon-id simon-id marked this pull request as ready for review December 13, 2024 16:13
@simon-id simon-id requested review from a team as code owners December 13, 2024 16:13
cbeauchesne
cbeauchesne previously requested changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI still failing on added tests

@cbeauchesne cbeauchesne dismissed their stale review December 13, 2024 19:36

never mind, it's not a PR to main

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/appsec-login-events-v3 branch from bcbb560 to 78aa7bf Compare December 13, 2024 22:04
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested review from P403n1x87, wantsui, smola and jandro996 and removed request for a team December 13, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uurien uurien uurien approved these changes

@cbeauchesne cbeauchesne cbeauchesne left review comments

@P403n1x87 P403n1x87 Awaiting requested review from P403n1x87 P403n1x87 was automatically assigned from DataDog/apm-python

@wantsui wantsui Awaiting requested review from wantsui wantsui was automatically assigned from DataDog/apm-python

@smola smola Awaiting requested review from smola smola was automatically assigned from DataDog/asm-java

@jandro996 jandro996 Awaiting requested review from jandro996 jandro996 was automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simon-id @uurien @cbeauchesne @manuel-alvarez-alvarez