Add sleep in batchvote rpc #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bushstar
reviewed
Mar 9, 2023
src/masternodes/rpc_proposals.cpp
Outdated
| // relay the TXs as it works through. Otherwise, the main | ||
| // chain can be locked for too long that prevent broadcasting of | ||
| // TXs | ||
| std::this_thread::sleep_for(std::chrono::seconds(1)); |
There was a problem hiding this comment.
1 second seems like a long time. Have we tested smaller time periods?
There was a problem hiding this comment.
Edit: Moved rationale to main thread.
There was a problem hiding this comment.
Switched to 0.5s in light of the perf. observations data with -walletfastselect
prasannavl
added
the
v/next-release
Bushstar
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind fix
Node can become too busy to broadcast during batch voting. This workarounds it by for now by adding an idle period to process messages in between.
Wait time is just added as an escape hatch for now since it's meant for limited advanced uses cases and not for widespread adoption.
Note: The node also needs to keep catching up on other things like validating incoming blocks, possibly other minor RPCs, etc in between in this time the sleep is added.
Rationale: Ideal targets are institutions that vote on behalf of users, so likely 500 to 3000 votes at a time using the current single threaded wallet logic that's held by global locks.
Considering these nodes might have many addresses per wallet, using a large time factor of 30s - 5m to sign the TX.
Overhead is high only on low counts, where the consumers are better off using single vote.
Edit: Now using 0.5s as default, since
-walletfastselecthas much better observed perf. characteristics. This should allows us to turn it as a default and just use a 0.5s for safety for now.