Version 3.2.8

[dcorral]

Items

• Replace more require usages #1822
• Adds coin select flags to defid with option to override from CLI #1820
• Remove Require from governance attributes #1819
• net: rate limit the processing of incoming addr messages #1818
• In CreateTransaction pass coinSelectOpts to AvailableCoin. Remove dead code. #1814
• Fix GetDecimalString typo #1812
• Rename CLoanCollaterals to CVaultAssets #1811
• Switch assert to propogating error so it doesn't crash on corrupt data #1809
• Add RPC metadata capability and coin selection options #1808
• Add sleep in batchvote rpc #1810

Prerequisites

Previous master commit: b7816112eecb0fc9cf10d2188ba71c89d94a9ab9

• Functional tests
• Jellyfish tests
• CI diff checks
• Other CI analyzer checks

Prepare Version

• Bump Version (configure.ac)
  • <major>: Planned consensus upgrades and major breaking releases
  • <minor>: Unplanned consensus upgrades and fixes
  • <patch>: Non-breaking releases (API additions are accepted)
• Major / Minor upgrade-only:
  • Bump Protocol Version (version.h)

Release notes checklist

• Release type:
  • Mandatory: Consensus
  • Recommended: Significant fixes, index changes, performance, or major additions
  • Optional: Everything else, including minor RPC additions
• Indexes
  • Reindex mandatory
  • Reindex optional (added features / fixes but node still continues without affecting consensus)
  • Reindex not-needed
• Document RPC changes since previous release
• Add release notes as comment below that's to be copied over once release is tagged

Planned release checklist / Post-release checklist

Note: Manual ops that's to be automated eventually after which it's a single checkpoint in pre-req.

• Approximate block height during point of this PR: https://defiscan.live/blocks/2763254

All versions

• Setup node with scratch sync
  • VM: mainnet-ain-scratch-<version>[+flags]
• Setup node with recent snap
  • VM: mainnet-ain-snap-<height>-<version>[+flags]

If re-index not mandatory:

• Update rollover node that's been incrementally rolled over from scratch
  • VM: mainnet-ain-rollover-scratch[+flags]
• Update rollover node from last version from one of it's snapshots
  • VM: mainnet-ain-rollover-snap-<height>[+flags]

Checks

• Sync to tip (atleast till <rel-time-height>+120 blocks)
• Verify diff checks after across above VMs

Note: <version>: Separated units by _` if dot not allowed

[dcorral]

Recommended Upgrade

• Security improvements
  • Rate limit ADDR P2P messages.
    • This prevents a potential DoS attack vector where malicious actors can cause resource exhaustion of the node host.
• Performance improvements
  • -walletfastselect flag can be used to speed up UTXO selection for large wallets
    • This only works for simple utxo unlock scripts.
    • Using this option will fail to select complex scripts unlock scripts like multi-sig.
    • This can be set as a global default in defid or passed to defi-cli to set per-request context.

Upgrade Notes

• For >= 3.2.4, no reindex needed. Drop-in upgrade.
• For >= 3.2.0 and <= 3.2.3, reindex is recommended, but optional and can be drop-in upgrade.
• For nodes >=3.0.x, one of the following is required:
  • Sync from any of snapshots from the DeFiChain team (below)
• For all other updates, one of the following is required: a fresh sync, the most recent snapshot.
• For nodes that are being restored from recent snapshot, as with all updates before: -rescan for the wallet txs and additionally -spv_resync for users who hold BTC. If either isn't used, they may not be shown in the wallet until rescanned/resynced.

Flag Changes

• Both defi-cli and defid:
  • Added:
    • walletfastselect
    • walletcoinoptskipsolvable
    • walletcoinopteagerselect
• defid:
  • Added:
    • maxaddrratepersecond
    • maxaddrprocessingtokenbucket

RPC Changes

• getpeerinfo:
  • Added:
    • addr_processed
    • addr_rate_limited

Additional Notes

• None

Network Snapshot

• [Asia] https://defi-snapshots.s3.ap-southeast-1.amazonaws.com/index.txt
• [EU] https://defi-snapshots-europe.s3.eu-central-1.amazonaws.com/index.txt
• [Sydney] https://defi-snapshots-sydney.s3.ap-southeast-2.amazonaws.com/index.txt
• [US] https://defi-snapshots-us.s3.amazonaws.com/index.txt

What’s Changed

• [Auto generated in release GH page]