Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Require usage #2582

Merged
merged 10 commits into from
Oct 16, 2023
Merged

Remove Require usage #2582

merged 10 commits into from
Oct 16, 2023

Conversation

Bushstar
Copy link
Member

@Bushstar Bushstar commented Oct 13, 2023 •
edited
Loading

Summary

  • Remove Require usage from source code due to poor performance.
  • Requires full sync test before merging.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@Bushstar Bushstar changed the title WIP: Remove Require usage Remove Require usage Oct 14, 2023
@Bushstar Bushstar merged commit 1b00f53 into master Oct 16, 2023
15 of 18 checks passed
@Bushstar Bushstar deleted the bush/remove-require branch October 16, 2023 11:45
Bushstar added a commit that referenced this pull request Oct 17, 2023
@Bushstar
Revert "Remove Require usage (#2582)"
03ba17d 
This reverts commit 1b00f53.
Bushstar added a commit that referenced this pull request Oct 17, 2023
@Bushstar
Remove Require usage (#2582)
9dc0a4d 
* Remove Require usage from outside dfi/consensus

* Remove Require from gov, txvisitor, mn, oracles, proposals and tokens

* Accounts and poolpairs

* Smart contracts

* Vaults

* Loans

* ICX

* Remove Require
prasannavl pushed a commit that referenced this pull request Oct 17, 2023
@Bushstar
Remove Require usage (#2582) (#2595)
56969d3 
* Remove Require usage from outside dfi/consensus

* Remove Require from gov, txvisitor, mn, oracles, proposals and tokens

* Accounts and poolpairs

* Smart contracts

* Vaults

* Loans

* ICX

* Remove Require
prasannavl added a commit that referenced this pull request Oct 24, 2023
@prasannavl
Fix token check bugs from #2582
4d80d42
@prasannavl prasannavl mentioned this pull request Oct 24, 2023
Merged
9 tasks
prasannavl added a commit that referenced this pull request Oct 24, 2023
@prasannavl
Fix token check bugs from #2582 (#2612)
0fd8107 
* Fix token check bugs from #2582

* fix fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Bushstar