Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix token check bugs from #2582 #2612

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Fix token check bugs from #2582 #2612

merged 2 commits into from
Oct 24, 2023

Conversation

prasannavl
Copy link
Member

@prasannavl prasannavl commented Oct 24, 2023 •
edited
Loading

Summary

  • Remove Require usage #2582 had introduced an accidental bug on token checks.
  • Full syncs succeeded as it relaxed the checks, but is a critical fix

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

sieniven
sieniven previously approved these changes Oct 24, 2023
View reviewed changes
@prasannavl prasannavl merged commit 0fd8107 into master Oct 24, 2023
12 of 13 checks passed
@prasannavl prasannavl deleted the pvl/fix-token-checks branch October 24, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sieniven sieniven sieniven left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prasannavl @sieniven