Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance notification messages #1158

Closed
2 tasks
madchap opened this issue May 21, 2019 · 0 comments
Closed
2 tasks

Enhance notification messages #1158

madchap opened this issue May 21, 2019 · 0 comments
Assignees
@devEricA-zz
Labels
enhancement

Comments

@madchap
Copy link
Contributor

madchap commented May 21, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe
Messages sent to Slack do not provide enough relevant information, except maybe for when adding a note to a finding.

Describe the solution you'd like
A contextualized message should be sent, depending the event being notified.

And also, it seems some things do not trigger messages, such as:

  • Modifying a finding
  • Importing a new report
    (complete list as noticing)

For these, additional work on the UI may be needed.
@madchap madchap mentioned this issue Jun 4, 2019
Closed
@madchap madchap changed the title Enhance Slack notification messages Enhance notification messages Jun 11, 2019
@devEricA-zz devEricA-zz mentioned this issue Jul 30, 2019
Merged
devGregA added a commit that referenced this issue Aug 2, 2019
@devGregA
Merge pull request #1437 from devEricA/dev
cdf202b 
Notifications Overhaul #1158, Enhancement #1154, and more....
@Maffooch Maffooch closed this as completed Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devEricA-zz devEricA-zz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@madchap @devEricA-zz @Maffooch