Notifications Overhaul #1158, Enhancement #1154, and more.... #1437
Conversation
|
I think this is a great start, thank you!
So, everyone still gets the email, only the intended recipient is explicitly mentioned correct? |
devEricA-zz
changed the title
|
Managed to also knock out #1154. A name field was created to allow a unique distinction between jira configurations. |
devEricA-zz
changed the title
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
dojo/templates/dojo/view_test.html
Outdated
| <option value="High">High</option> | ||
| <option value="Critical">Critical</option> | ||
| </select><br/><br/> | ||
| <b>Status</b> <input id="id_status" name="status" type="checkbox" alt="Select to enable"/><br/> |
There was a problem hiding this comment.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.
dojo/templates/dojo/view_test.html
Outdated
| <span>Mitigated</span> | ||
| </label> | ||
| {% if "enable_jira"|get_system_setting %} | ||
| <b>Push to JIRA</b> <input id="id_push_tojira" name="push_to_jira" type="checkbox" alt="Select to push to JIRA"/><br/> |
There was a problem hiding this comment.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.
dojo/templates/dojo/view_test.html
Outdated
| {% endfor %}` | ||
| </select> | ||
| </label> | ||
| <input type="submit" class="btn btn-sm btn-primary" value="Submit"/> |
There was a problem hiding this comment.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input.
|
These commits are for #1438 and #1281. Retire.js scan was fixed for the given file provided in #1438, and a comment icon appears for any findings with notes. Hovering over the commenting Icon displays the most recent note for the finding. Additionally, the Bulk edit menus and page numbering for view test and findings list were re-positioned. The bulk edit menu for view test will now display inside the finding window, and the page number widget in view test's finding window was moved to the top. The bulk edit menu for findings list now appears under the page number widget. NOTE: The Retire.js Sample Scan file provided in the sample scan repo continues to break when uploaded with Retire.js selected. I am in the process of replacing that file with the one provided in #1438 . This will be the last commit I will make to this request, unless if the Travis CI Fails. |
devEricA-zz
changed the title
This is a series of changes that I made to Defectdojo's Notifications as a response to Issue #1158
The following notifications were changed:
The following events now trigger a notification:
Are there any other events that I should tag a notification to?