Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nix channel placement #304

Merged
merged 3 commits into from
Mar 8, 2023

Conversation

Hoverbear
Copy link
Contributor

Description

We don't need to do this at all!

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@Hoverbear Hoverbear self-assigned this Mar 6, 2023
@Hoverbear Hoverbear changed the title Hoverbear/ds 698 remove nix channel placement Remove nix channel placement Mar 6, 2023
@Hoverbear Hoverbear added this to the v0.6.0 milestone Mar 6, 2023
@Hoverbear Hoverbear marked this pull request as ready for review March 6, 2023 19:37
@Hoverbear Hoverbear requested a review from cole-h March 6, 2023 19:37
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. But depending on the 2.14 fallout, we might need to resurrect this for legacy CLI use cases.

@Hoverbear
Copy link
Contributor Author

Hmmm, should we block this until we find out?

@cole-h
Copy link
Member

cole-h commented Mar 8, 2023

I think it would be fine as-is, but if (when) we switch to 2.14 as the default for this installer, we'll probably want to make sure it's fine this is removed.

@Hoverbear Hoverbear merged commit 5fe7dd9 into main Mar 8, 2023
@Hoverbear Hoverbear deleted the hoverbear/ds-698-remove-nix-channel-placement branch March 8, 2023 17:24
Hoverbear added a commit that referenced this pull request Mar 8, 2023
@Hoverbear Hoverbear mentioned this pull request Mar 8, 2023
6 tasks
Hoverbear added a commit that referenced this pull request Mar 8, 2023
@RaitoBezarius
Copy link

Does this mean that this installer cannot install channels at all?

@Hoverbear
Copy link
Contributor Author

The installer has no options for channels, no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants