Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(credssp): support for Kerberos #260

Merged
merged 57 commits into from
Nov 17, 2023
Merged

feat(credssp): support for Kerberos #260

merged 57 commits into from
Nov 17, 2023

Conversation

irvingoujAtDevolution
Copy link
Contributor

Bump sspi-rs version to the lastest master, restructure the network accessing model when using credssp.

Draft Until the formatter/linter change is merged, since there are changes overlap.

Reviews welcomed, will fix then rebase to master after the linter change is merged

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023 •
edited
Loading

Coverage Report 🤖 ⚙️

Past:
Total lines: 25867
Covered lines: 16336 (63.15%)

New:
Total lines: 25736
Covered lines: 16338 (63.48%)

Diff: +0.33%

[this comment will be updated automatically]

@CBenoit CBenoit self-assigned this Nov 2, 2023
@CBenoit CBenoit self-requested a review November 2, 2023 19:32
CBenoit
CBenoit reviewed Nov 3, 2023
View reviewed changes
crates/ironrdp-client/src/network_cllient.rs Outdated Show resolved Hide resolved
crates/ironrdp-web/Cargo.toml Outdated Show resolved Hide resolved
@irvingoujAtDevolution irvingoujAtDevolution force-pushed the ARC-139-IronRDP-Web-based-KDC-proxy branch 3 times, most recently from 7091677 to d01f832 Compare November 6, 2023 16:36
@irvingoujAtDevolution irvingoujAtDevolution marked this pull request as ready for review November 6, 2023 18:56
@irvingoujAtDevolution irvingoujAtDevolution mentioned this pull request Nov 10, 2023
Merged
@irvingoujAtDevolution
Copy link
Contributor Author

Fixed NTLM not authenticate problem, see Devolutions/sspi-rs#187

This was referenced Nov 15, 2023
Merged
Closed
@CBenoit CBenoit added A-native-client Area: Native client (ironrdp-client) A-web-client Area: Web client (ironrdp-web, iron-remote-gui, iron-svelte-client) A-core Area: Core tier A-credssp Area: CredSSP (delicate) labels Nov 15, 2023
CBenoit
CBenoit approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s merge this now, I’ll send a follow up PR for the remaining suggestions.

@CBenoit CBenoit enabled auto-merge (squash) November 17, 2023 03:50
@CBenoit CBenoit merged commit 5530550 into master Nov 17, 2023
6 checks passed
@CBenoit CBenoit deleted the ARC-139-IronRDP-Web-based-KDC-proxy branch November 17, 2023 04:12
CBenoit added a commit that referenced this pull request Nov 17, 2023
@CBenoit
refactor(credssp): follow up to #260
3e71bcf
@CBenoit CBenoit mentioned this pull request Nov 17, 2023
Merged
CBenoit added a commit that referenced this pull request Nov 17, 2023
@CBenoit
refactor(credssp): follow up to #260
e08c189
CBenoit added a commit that referenced this pull request Nov 17, 2023
@CBenoit
refactor(credssp): follow up to #260
121cc5f
CBenoit added a commit that referenced this pull request Nov 17, 2023
@CBenoit
refactor(credssp): follow up to #260 (#287)
8fc213e
@CBenoit CBenoit mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBenoit CBenoit CBenoit approved these changes

Assignees

@CBenoit CBenoit

Labels
A-core Area: Core tier A-credssp Area: CredSSP (delicate) A-native-client Area: Native client (ironrdp-client) A-web-client Area: Web client (ironrdp-web, iron-remote-gui, iron-svelte-client)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irvingoujAtDevolution @CBenoit