Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(credssp): follow up to #260 #287

Merged
merged 1 commit into from
Nov 17, 2023
Merged

refactor(credssp): follow up to #260 #287

merged 1 commit into from
Nov 17, 2023

Conversation

CBenoit
Copy link
Member

@CBenoit CBenoit commented Nov 17, 2023

Applies follow-up suggestions for #260

@CBenoit CBenoit enabled auto-merge (squash) November 17, 2023 05:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2023 •
edited
Loading

Coverage Report 🤖 ⚙️

Past:
Total lines: 25736
Covered lines: 16337 (63.48%)

New:
Total lines: 25723
Covered lines: 16337 (63.51%)

Diff: +0.03%

[this comment will be updated automatically]

irvingoujAtDevolution
irvingoujAtDevolution approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@irvingoujAtDevolution irvingoujAtDevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for all the changes to improve the code quality. Will follow the style guide more closely next time.

@CBenoit CBenoit merged commit 8fc213e into master Nov 17, 2023
6 checks passed
@CBenoit CBenoit deleted the follow-up-to-260 branch November 17, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvingoujAtDevolution irvingoujAtDevolution irvingoujAtDevolution approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CBenoit @irvingoujAtDevolution