Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running without a message bus #285

Closed
DiamondJoseph opened this issue Aug 1, 2023 · 2 comments
Closed

Enable running without a message bus #285

DiamondJoseph opened this issue Aug 1, 2023 · 2 comments
Labels
cli Relates to CLI code client Relates to client code enhancement New feature or request good first issue Good for newcomers messaging Relates to asynchronous messaging code python Pull requests that update Python code

Comments

@DiamondJoseph
Copy link
Contributor

No description provided.

@DiamondJoseph DiamondJoseph added enhancement New feature or request good first issue Good for newcomers python Pull requests that update Python code labels Aug 1, 2023
@callumforrester
Copy link
Contributor

Blueapi can now tolerate a message bus connection failure on startup, but is not very usable. I've opened two separate tickets to fix that: #426 and #427.

I do still think this issue is valid as we want blueapi to be able to start up this way by design rather than just when the message bus fails, will post details below.

@callumforrester
Copy link
Contributor

As a developer I want to configure the bluepai server and CLI to work without a message bus so that I can easily run it up without messing around with external dependencies.

Possible Solution

The way I suggest to do this is make StompConfig in config.py an optional part of ApplicationConfig and run mypy. It will highlight where the stomp config is being used on the assumption that it is definitely there and where None-checks are needed. Ultimately stomp can be made optional.

Acceptance Criteria

  • If a user does not supply a stomp config in the config file, blueapi server does not attempt to connect to a message bus on startup
  • If a user does not supply a stomp config in the config file, blueapi client does not attempt to connect to a message bus on running a plan
  • There are tests that prove both paths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Relates to CLI code client Relates to client code enhancement New feature or request good first issue Good for newcomers messaging Relates to asynchronous messaging code python Pull requests that update Python code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants