Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove message bus dependency #433

Merged
merged 12 commits into from
Apr 26, 2024
Merged

Remove message bus dependency #433

merged 12 commits into from
Apr 26, 2024

Conversation

ZohebShaikh
Copy link
Contributor

@ZohebShaikh ZohebShaikh commented Apr 24, 2024 •
edited
Loading

closes #426 #427 #285

@codecov Codecov
Copy link

codecov bot commented Apr 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.45455% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.96%. Comparing base (4440433) to head (40abc55).

Files Patch % Lines
src/blueapi/service/handler.py 92.85% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   89.40%   89.96%   +0.56%     
==========================================
  Files          43       43              
  Lines        1802     1814      +12     
==========================================
+ Hits         1611     1632      +21     
+ Misses        191      182       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZohebShaikh ZohebShaikh requested review from joeshannon and removed request for callumforrester April 24, 2024 14:53
joeshannon
joeshannon requested changes Apr 25, 2024
View reviewed changes
tests/messaging/test_stomptemplate.py Outdated Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
DiamondJoseph
DiamondJoseph requested changes Apr 25, 2024
View reviewed changes
tests/test_cli.py Outdated Show resolved Hide resolved
DiamondJoseph
DiamondJoseph requested changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicky bits, you can argue about the wording of the exception if you want.

Testing this out on the CLI the behaviour is what I would expect.

src/blueapi/cli/cli.py Outdated Show resolved Hide resolved
tests/example_yaml/rest_config.yaml Outdated Show resolved Hide resolved
tests/example_yaml/valid_stomp_config.yaml Outdated Show resolved Hide resolved
tests/messaging/test_stomptemplate.py Outdated Show resolved Hide resolved
DiamondJoseph
DiamondJoseph requested changes Apr 26, 2024
View reviewed changes
tests/test_cli.py Outdated Show resolved Hide resolved
callumforrester
callumforrester requested changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, just a few minor points

src/blueapi/cli/amq.py Outdated Show resolved Hide resolved
src/blueapi/service/handler.py Outdated Show resolved Hide resolved
src/blueapi/messaging/stomptemplate.py Outdated Show resolved Hide resolved
src/blueapi/cli/cli.py Outdated Show resolved Hide resolved
@DiamondJoseph DiamondJoseph self-requested a review April 26, 2024 07:43
DiamondJoseph
DiamondJoseph approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once Callum's changes have been made

@callumforrester
Copy link
Contributor

@ZohebShaikh please could you also reference the issues this fixes in the PR description?

@ZohebShaikh ZohebShaikh force-pushed the remove-message-bus-dependency branch from 6a2577a to 12f77b5 Compare April 26, 2024 10:26
This was referenced Apr 26, 2024
Closed
Closed
@ZohebShaikh ZohebShaikh merged commit f5e160c into main Apr 26, 2024
24 checks passed
@ZohebShaikh ZohebShaikh deleted the remove-message-bus-dependency branch April 26, 2024 12:04
ZohebShaikh added a commit that referenced this pull request May 7, 2024
@ZohebShaikh
Remove message bus dependency (#433)
871d775 
closes #426
#427
#285
@abbiemery abbiemery mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiamondJoseph DiamondJoseph DiamondJoseph approved these changes

@joeshannon joeshannon joeshannon approved these changes

@callumforrester callumforrester callumforrester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot run plans without a message bus (server)
4 participants
@ZohebShaikh @callumforrester @joeshannon @DiamondJoseph