Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for python 3.9 #416

Closed
DiamondJoseph opened this issue Apr 10, 2024 · 0 comments · Fixed by #418
Closed

Drop support for python 3.9 #416

DiamondJoseph opened this issue Apr 10, 2024 · 0 comments · Fixed by #418

Comments

@DiamondJoseph
Copy link
Contributor

DiamondJoseph commented Apr 10, 2024 •
edited
Loading

Dodal no longer supports 3.9 due to using the new union operand. Blueapi CI is failing as a result.
Link to dodal change: DiamondLightSource/dodal#411

As we are matching Numpy's deprecation policy, this is fair game as of April 5th, and 3.10 will be supported until Apr 04, 2025

https://numpy.org/neps/nep-0029-deprecation_policy.html
@callumforrester callumforrester mentioned this issue Apr 11, 2024
Merged
joeshannon added a commit that referenced this issue Apr 12, 2024
@joeshannon
Drop support for python 3.9
678b079 
Fixes #416.
@joeshannon joeshannon mentioned this issue Apr 12, 2024
Closed
joeshannon added a commit that referenced this issue Apr 12, 2024
@callumforrester @joeshannon
Drop Support for Python3.9 (#418)
2f1dd36 
Fixes #416

Remove Python3.9 check from CI and enforce python>=3.10 in
pyproject.toml.

Adapt to PEP 604 type hint changes and other minor import
changes.

---------

Co-authored-by: Joe Shannon <joe.shannon@diamond.ac.uk>
ZohebShaikh pushed a commit that referenced this issue May 7, 2024
@callumforrester @joeshannon @ZohebShaikh
Drop Support for Python3.9 (#418)
62bd9a5 
Fixes #416

Remove Python3.9 check from CI and enforce python>=3.10 in
pyproject.toml.

Adapt to PEP 604 type hint changes and other minor import
changes.

---------

Co-authored-by: Joe Shannon <joe.shannon@diamond.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@DiamondJoseph