Drop Support for Python3.9 #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeshannon
approved these changes
Apr 12, 2024
Remove Python3.9 check from CI and encorce python>=3.10 in pyproject.toml
DiamondJoseph
approved these changes
Apr 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
==========================================
- Coverage 89.41% 89.38% -0.03%
==========================================
Files 43 43
Lines 1805 1800 -5
==========================================
- Hits 1614 1609 -5
Misses 191 191 ☔ View full report in Codecov by Sentry. |
DiamondJoseph
approved these changes
Apr 12, 2024
ZohebShaikh
pushed a commit
that referenced
this pull request
May 7, 2024
Fixes #416 Remove Python3.9 check from CI and enforce python>=3.10 in pyproject.toml. Adapt to PEP 604 type hint changes and other minor import changes. --------- Co-authored-by: Joe Shannon <joe.shannon@diamond.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416
Remove Python3.9 check from CI and encorce python>=3.10 in
pyproject.toml