Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Pydantic 2 #564

Merged
merged 8 commits into from
Aug 20, 2024
Merged

Upgrade to Pydantic 2 #564

merged 8 commits into from
Aug 20, 2024

Conversation

callumforrester
Copy link
Contributor

Fixes #273

Supersedes #449

Currently scanspec is spoofed, we need bluesky/scanspec#122 merged before we can revert.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.97%. Comparing base (fd41e57) to head (ba38a8a).
Report is 1 commits behind head on main.

Files Patch % Lines
src/blueapi/core/context.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
+ Coverage   92.84%   92.97%   +0.12%     
==========================================
  Files          40       40              
  Lines        1818     1823       +5     
==========================================
+ Hits         1688     1695       +7     
+ Misses        130      128       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZohebShaikh ZohebShaikh force-pushed the 273-pydantic-2 branch 3 times, most recently from 709a960 to 664eae7 Compare August 13, 2024 12:52
@ZohebShaikh ZohebShaikh marked this pull request as ready for review August 13, 2024 14:04
pyproject.toml Outdated Show resolved Hide resolved
src/blueapi/service/main.py Show resolved Hide resolved
src/blueapi/cli/format.py Show resolved Hide resolved
dev-requirements.txt Show resolved Hide resolved
src/blueapi/core/context.py Show resolved Hide resolved
src/blueapi/utils/base_model.py Show resolved Hide resolved
tests/service/test_openapi.py Outdated Show resolved Hide resolved
tests/test_cli.py Outdated Show resolved Hide resolved
@ZohebShaikh ZohebShaikh merged commit 8217396 into main Aug 20, 2024
24 checks passed
@ZohebShaikh ZohebShaikh deleted the 273-pydantic-2 branch August 20, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Pydantic2
3 participants