-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Pydantic 2 #564
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumforrester
force-pushed
the
273-pydantic-2
branch
from
July 19, 2024 09:20
e2dcc61
to
d72c934
Compare
Closed
callumforrester
force-pushed
the
273-pydantic-2
branch
from
August 8, 2024 06:33
d72c934
to
57966fa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
==========================================
+ Coverage 92.84% 92.97% +0.12%
==========================================
Files 40 40
Lines 1818 1823 +5
==========================================
+ Hits 1688 1695 +7
+ Misses 130 128 -2 ☔ View full report in Codecov by Sentry. |
ZohebShaikh
force-pushed
the
273-pydantic-2
branch
3 times, most recently
from
August 13, 2024 12:52
709a960
to
664eae7
Compare
ZohebShaikh
force-pushed
the
273-pydantic-2
branch
from
August 13, 2024 12:58
664eae7
to
657c53f
Compare
DiamondJoseph
requested changes
Aug 14, 2024
DiamondJoseph
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #273
Supersedes #449
Currently scanspec is spoofed, we need bluesky/scanspec#122 merged before we can revert.