Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translations #276

Closed
FrutyX opened this issue Sep 9, 2021 · 12 comments
Closed

Missing translations #276

FrutyX opened this issue Sep 9, 2021 · 12 comments

Comments

@FrutyX
Copy link
Collaborator

FrutyX commented Sep 9, 2021

There are some missing translations that needs to be added completely.

I've mentioned this before, but a whole new Issue will be probably best.

On/Off buttons in settings are missing:

trans

In auction&packages sorting - Threat is missing, the rest is translated:

trans2

That's all... for now, muheheh.

@GramThanos
Copy link
Member

Removed text from settings On/Off toggles
image

@FrutyX
Copy link
Collaborator Author

FrutyX commented Sep 14, 2021

Unexpected, looking good.

the-universe-tim-and-eric-mind-blown

@SleepingShadow-bit
Copy link
Collaborator

Look good, but isn't good for the GCA documentation.. U know =D

@GramThanos
Copy link
Member

You are a part of this now 😄. You shall vote for it.

@SleepingShadow-bit
Copy link
Collaborator

It's Okey. I will update the documentation. It looks really good.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Sep 14, 2021

Just need to add Threat to the translation list and we done here, this is a very nice change, it looks modern and the options are more recognizable, really nice.

@GramThanos
Copy link
Member

GramThanos commented Sep 14, 2021

These should autoload from the UI. Visit the your turma player and check again if the threat is translated.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Sep 14, 2021

After visiting Turma profile, it is indeed translated, noice, I am silent then, thanks for the upgrades!

Close whenever.

GramThanos added a commit that referenced this issue Sep 14, 2021
@FrutyX
Copy link
Collaborator Author

FrutyX commented Sep 21, 2021

You know, if you ever wanted to make GCA fully translatable, this [picture], it's no big deal, but it cannot be translated. Also, if you added that, I suggest adding a line where you mention to write to you only in english.

trans

@GramThanos
Copy link
Member

Personally, I don't think we should translate that. We are already getting many Facebook messages in other languages.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Sep 21, 2021

Well, Facebook is Facebook, no surprise, but this seems like an developer preference, some on their projects have their "about" section translated while others not. It's your decision and I respect that.

@FrutyX
Copy link
Collaborator Author

FrutyX commented Dec 8, 2021

Nothing else to do here, done and done, closing.

Re-open if needed.

@FrutyX FrutyX closed this as completed Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants