Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auction sorting not working #235

Closed
ahoj1234 opened this issue Mar 11, 2021 · 10 comments
Closed

Auction sorting not working #235

ahoj1234 opened this issue Mar 11, 2021 · 10 comments

Comments

@ahoj1234
Copy link

Describe the bug
If you open auction and try sorting by damage (highest to lowest) it seems like the script is sorting only 2 digits. Which is not wanted for weapons as weapons has also 3 digit damage status.

Screenshots
image

@GramThanos
Copy link
Member

Ok, I need to rescript this one and merge it with packages search too.

@GramThanos GramThanos changed the title Auction sorting not working (sorts by 2 first digits only) Auction sorting not working Mar 12, 2021
@FrutyX
Copy link
Collaborator

FrutyX commented Sep 8, 2021

@GramThanos

Uhh, I was just checking some bugs here, and I wanted to test this one, instead of that, I found completely something different, I am not sure if I have something wrong on my side, but I don't see any auction (filter) settings at all and I am also getting an console error:

auction.js?4.3.5&built=1631143038779:543 Uncaught TypeError: Cannot set properties of null (setting 'level')
at Object.initKeywordMap (auction.js?4.3.5&built=1631143038779:543)
at Object.init (auction.js?4.3.5&built=1631143038779:456)
at Object.inject (auction.js?4.3.5&built=1631143038779:32)
at fireLoad (auction.js?4.3.5&built=1631143038779:828)

error

I've tried 4.3.4, no change. Tested this with clean GCA settings (default).

Chrome v95 (Canary) detected this error, meanwhile Chrome v93 is not showing any error, but I don't see the auction filter either, what a mess.

@FrutyX
Copy link
Collaborator

FrutyX commented Sep 8, 2021

@GramThanos not sure if you would notice if I just edited my previous post, so sorry for spam.

I just tested it on Edge, and it works normally, no errors, Chrome, Chrome.... you naughty boy.

Edit: Okay, Chrome isn't alone, Firefox is showing the same error.

But I remember I was using this feature some time ago, so it worked, but it's been a while I think and something has changed, I guess.

@FrutyX
Copy link
Collaborator

FrutyX commented Sep 8, 2021

Is this a joke? Is there somewhere a hidden troll?

It loaded normally now, so I have no clue, filter is visible and there is no error, perhaps it's under some specific circumstances?

Sorry for waking you up Gram, not sure what is this, I thought I found a bug, perhaps I did, but it's .... complicated.

@GramThanos
Copy link
Member

Don't worry, I will test it tomorrow.
If I remember the code correctly the level read failed. I think this was not my code through :P

@FrutyX
Copy link
Collaborator

FrutyX commented Sep 8, 2021

I was playing with my settings due to #262 and it seems this error goes away after you visit the auction page a few times, it's like addon is loading your profile, settings, Gladiatus or something.

I reset my settings again, and this error is back, after a few reloads, it's gone. So perhaps it's my fault that I test bugs when I have been testing GCA settings, but I leave it up to you, if you want to test it or rework so it will not occur, it is definitely connected to GCA settings and the way GCA reads Gladiatus.

@GramThanos
Copy link
Member

This is also linked to #276

@FrutyX
Copy link
Collaborator

FrutyX commented Oct 28, 2021

auct

This one is easy to reproduce, 2 and 3 digits does not work here together well.

Low priority for 4.3.5 prep tho.

@GreatApo
Copy link
Member

GreatApo commented Dec 22, 2021

String sorting changed to number sorting, fixed 1a3feeb

@FrutyX let me know if it works for you too.

@GreatApo GreatApo reopened this Dec 22, 2021
@FrutyX
Copy link
Collaborator

FrutyX commented Dec 22, 2021

Unless I am extremely lucky, I think yes, you did fixed it.

@GreatApo I found out that you are very good at fixing things (sorry Gram, maybe next time) 😃.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants