ABLASTR: Fix Stray Include in ChargeDeposition #3406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This include into WarpX should not be here and is unused. Same as ECP-WarpX#3393.
dpgrote
pushed a commit
to dpgrote/WarpX
that referenced
this pull request
Nov 22, 2022
This include into WarpX should not be here and is unused. Same as ECP-WarpX#3393.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The include in #3393 was not stray, the file uses
GetPosition.We might want to add a development branch (#3407) that also changes the WarpX particle type for hacking in ECP-WarpX/impactx#245
Otherwise we need to template ABLASTR container stuff, which is more work and will not be needed long term with the new layout.