Use the new SoA Data Structure #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
reviewed
Sep 13, 2022
This was referenced Sep 16, 2022
ax3l
reviewed
Sep 17, 2022
ax3l
reviewed
Sep 17, 2022
3 tasks
Thierry992
force-pushed
the
tiri_impactx
branch
from
464ca3e
to
5d95372
Compare
ax3l
reviewed
Sep 28, 2022
ax3l
reviewed
Sep 28, 2022
ax3l
reviewed
Sep 28, 2022
| @@ -142,6 +135,7 @@ namespace impactx | |||
| */ | |||
| auto old_np = particle_tile.numParticles(); | |||
| auto new_np = old_np + pinned_tile.numParticles(); | |||
| amrex::AllPrint() << "old_np=" << old_np << " new_np=" << new_np << "\n"; | |||
There was a problem hiding this comment.
Needs to be updated in AMReX pls :)
See: AMReX-Codes/amrex#2878 (comment)
Thierry992
force-pushed
the
tiri_impactx
branch
from
3b0749d
to
ce90eae
Compare
Adapting to SoA structures Link the CMake file to Axel Warpx branch Avoid branch conflicts Correction of ParIter and ConstParIter Adding corrections to make_alike function call Update Diagnostics Correction of the ParIter loop Still adaptating ImpactX to SoAParticle Update Init Note: AMReX-Codes/amrex#2878 (comment) Adapted the PushSingleParticle function to SoAParticle
This was referenced Apr 17, 2023
|
Continued in #348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting the impactx code with the new SoA Particle structure we created in AMReX. Main changes are related to the structures declarations and to the Parallel-for-loops where we access the particles data.
To Do
Third-party:
-DImpactX_PYTHON=ON):