This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix for nullptr deref when producers are waiting #5256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#4972 created a different calling path into `producer_plugin_impl::calculate_next_block_time` where there was no pending block state. As a result when the following conditions were met the code would dereference a null ptr: * the node was a producer, who _had_ produced during this processes lifetime OR replayed a block where they produced (so they have watermark data) * still in the active schedule of producers * experienced a gap in blocks of > 5 seconds (so they moved to our “waiting” mode) Credit goes to @heifner for the find
heifner
approved these changes
Aug 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4972 created a different calling path into
producer_plugin_impl::calculate_next_block_timewhere there was no pending block state. As a result when the following conditions were met the code would dereference a null ptr:Credit goes to @heifner for the find