Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix for nullptr deref when producers are waiting #5256

Merged
merged 1 commit into from
Aug 15, 2018

Commits on Aug 15, 2018

  1. Fix for nullptr deref when producers are waiting

    #4972 created a different calling path into `producer_plugin_impl::calculate_next_block_time` where there was no pending block state.  As a result when the following conditions were met the code would dereference a null ptr:
    
    * the node was a producer, who _had_ produced during this processes lifetime OR replayed a block where they produced (so they have watermark data)
    * still in the active schedule of producers
    * experienced a gap in blocks of > 5 seconds (so they moved to our “waiting” mode)
    
    Credit goes to @heifner for the find
    b1bart committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    b8f88da View commit details
    Browse the repository at this point in the history