-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Use transaction delay_sec in get_required_keys determination #5291
Conversation
Fix typos in contracts/eosiolib/types.h documentation
#4972 created a different calling path into `producer_plugin_impl::calculate_next_block_time` where there was no pending block state. As a result when the following conditions were met the code would dereference a null ptr: * the node was a producer, who _had_ produced during this processes lifetime OR replayed a block where they produced (so they have watermark data) * still in the active schedule of producers * experienced a gap in blocks of > 5 seconds (so they moved to our “waiting” mode) Credit goes to @heifner for the find
…roducer Fix for nullptr deref when producers are waiting
Remove unused variable
pretty_input.delay_sec is unsigned_int transacton::delay_sec; so, call inline function fc::seconds(pretty_input.delay_sec) to replace pretty_input.delay_sec, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there was accidental drive in the fc submodule. Also, I'm going to rebase this to release/1.2.x
so that it can be included as a bugfix in a patch release (it does seem like a bug)
Although not strictly needed for the this change the fc submodule update was intentional for the changes to varint.hpp. |
…o/eos into gh#5281-required-keys-delay
Resolves #5281