This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Pop back a delta with empty rows #9386 #9686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
In the SHiP delta creation, it may happen that when undo.new_values and undo.removed_values are empty, but undo.old_values is not empty, but the include_delta comparison evaluates to false for these objects and none of them are included on the delta's rows, creating a delta with empty rows. Detect this case and pop back the created table_delta object for this case.
This address issue #9386
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions