Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Pop back a delta with empty rows #9386 #9686

Merged
merged 1 commit into from
Nov 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions libraries/state_history/create_deltas.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,10 @@ std::vector<table_delta> create_deltas(const chainbase::database& db, bool full_
for (auto& row : undo.new_values) {
delta.rows.obj.emplace_back(true, pack_row(row));
}

if(delta.rows.obj.empty()) {
deltas.pop_back();
}
}
};

Expand Down
13 changes: 13 additions & 0 deletions unittests/state_history_tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,19 @@ class table_deltas_tester : public tester {
deltas_vector v;
};

BOOST_AUTO_TEST_CASE(test_deltas_not_empty) {
for (backing_store_type backing_store : { backing_store_type::CHAINBASE/* TODO: uncomment this , backing_store_type::ROCKSDB*/ } ) {
table_deltas_tester chain;
chain.set_backing_store(backing_store);

auto deltas = eosio::state_history::create_deltas(chain.control->kv_db(), false);

for(const auto &delta: deltas) {
BOOST_REQUIRE(!delta.rows.obj.empty());
}
}
}

BOOST_AUTO_TEST_CASE(test_deltas_account_creation) {
for (backing_store_type backing_store : { backing_store_type::CHAINBASE, backing_store_type::ROCKSDB }) {
table_deltas_tester chain;
Expand Down