Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit & Merging Infrastructure #139

Merged
merged 35 commits into from
Dec 17, 2020
Merged

Commit & Merging Infrastructure #139

merged 35 commits into from
Dec 17, 2020

Conversation

nelsonni
Copy link
Member

@nelsonni nelsonni commented Sep 17, 2020

Includes:

  • useBranchStatus hook for evaluating whether any currently open cards are associated with a specific repo and branch, and whether those cards have been modified according to a git.status check.
  • Updated runBuild function (from Impact Analysis #199):
    • Renamed runBuild to build function.
    • Returns Promise<string> containing build error codes, instead of Promise<void>.
    • Uses Node.js util.promisify to convert ChildProcess instances in build into Promise-based asynchronous constructs.
    • Allows for local-only branches, via Node.js fs.copyFile from base repository location.
  • MergeDialog component for selecting local branches from known git repositories, and analyzing whether they can be merged.
    • Styled component using material-ui/core/styles/createStyles, material-ui/core/styles/makeStyles, material-ui/core/styles/withStyles, and material-ui/core/styles/Theme.
    • Timeline of merge verification steps: (1) checking for new commits between branches, (2) checking for any merge conflicts or missing git.config fields, and (3) checking for build failures.
    • Expand the use of a shadow .syn/ directory to contain cloned repositories for testing merges.
  • git.branchLog function for determining commit delta between two branches in the same repository.
  • git.branchDiff function for determining files modified (and a coarse status indicator for the type of change) between two branches in the same repository.
  • git.merge for both test merging (using dryRun parameter flag) and actual merging.
  • git.clone for injecting local-only branch cloning functionality on top of isomorphic-git/clone.

Closes #69, closes #174, and closes #220.

@nelsonni nelsonni added the feature Feature requests or improvements label Sep 17, 2020
@nelsonni nelsonni added this to the v1.0.0 milestone Sep 17, 2020
@nelsonni nelsonni self-assigned this Sep 17, 2020
@nelsonni nelsonni marked this pull request as draft September 17, 2020 21:59
@nelsonni nelsonni linked an issue Sep 18, 2020 that may be closed by this pull request
8 tasks
@nelsonni nelsonni force-pushed the feature/custom-hooks branch from b6f87cd to acf9859 Compare September 21, 2020 21:49
@nelsonni nelsonni force-pushed the feature/custom-hooks branch from ad812b7 to def0616 Compare October 5, 2020 20:21
@nelsonni nelsonni force-pushed the feature/custom-hooks branch from 6ace4eb to 23dc4ba Compare October 12, 2020 23:29
@nelsonni nelsonni force-pushed the feature/custom-hooks branch from 07ce257 to b57baa2 Compare November 11, 2020 21:23
@nelsonni nelsonni force-pushed the feature/custom-hooks branch from 0437995 to 1c0ffd9 Compare November 17, 2020 20:46
@nelsonni nelsonni linked an issue Nov 18, 2020 that may be closed by this pull request
@nelsonni nelsonni force-pushed the feature/custom-hooks branch 2 times, most recently from 398796c to 489f582 Compare December 14, 2020 06:01
@nelsonni nelsonni force-pushed the feature/custom-hooks branch from 489f582 to 69c8281 Compare December 15, 2020 01:30
@nelsonni nelsonni marked this pull request as ready for review December 15, 2020 06:01
@nelsonni nelsonni requested a review from jettseale December 15, 2020 06:02
@nelsonni nelsonni merged commit 9555724 into development Dec 17, 2020
@nelsonni nelsonni deleted the feature/custom-hooks branch December 17, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature requests or improvements
Projects
None yet
2 participants