Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impact Analysis #199

Merged
merged 8 commits into from
Nov 6, 2020
Merged

Impact Analysis #199

merged 8 commits into from
Nov 6, 2020

Conversation

jettseale
Copy link
Collaborator

@jettseale jettseale commented Nov 3, 2020

Includes:

  • Function runBuild that:

    • Clones a specified remote repository into a given directory.
    • Identifies staged changes in a given local repository.
    • Copies the staged files from the local repository and moves them to the directory with the copied remote repository,
      maintaining correct pathing.
    • Creates a commit with the staged changes.
    • Runs a test build on the directory with the copied remote repository and newly added staged changes.
  • Temporary BuildButton to test out the runBuild function.

  • Some caveats:

    • runBuild is currently hard-coded to only be able to run builds from the phaser project.
    • BuildButton's call to runBuild contains hard-coded arguments. To test it out on your own machine, you'll have to change
      the 2nd and 3rd arguments which are paths to the local repo's and copied repo's directories.

@jettseale jettseale requested a review from nelsonni November 3, 2020 23:54
@nelsonni nelsonni added the feature Feature requests or improvements label Nov 4, 2020
Copy link
Member

@nelsonni nelsonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, just a few improvement requests to update before merging.

src/containers/runBuild.ts Outdated Show resolved Hide resolved
src/containers/runBuild.ts Outdated Show resolved Hide resolved
@jettseale jettseale requested a review from nelsonni November 5, 2020 23:51
@nelsonni nelsonni merged commit 63b2fdc into development Nov 6, 2020
@nelsonni nelsonni deleted the build-check branch November 6, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants