merge develop to create 1.3 release #207

mbjones · 2022-04-15T23:51:11Z

This is the PR for merging all 1.3 release changes into the main branch. Please review and suggest any changes that ar needed before the release can be made. I am opening it now as a location to collate release feedback. The PR incorporates many changes from 1.2, across many previously reviewed Pull Requests, so this is a last opportunity to catch small errors and issues. There are a few release details that still need to be committed to develop before the release is fully ready (such as assigning the new DOI and a few other maintenance issues described in #201 . Once those are committed to the develop branch we can proceed to merge this PR.

convention for including `spdx:checksum` for objects

@list

Feature 135 jsonld @list keyword

pull MBJones Restructured intro to variables section. into Issue27-forPullRequest branch

…cussion to advanced section

…data repository

make it clearer that data repository guidance is for describing a repository, not where repositories should necessarily start.

shows examples from other vocabularies with differnt structures. EarthRef does not have URI's associated with terms; SnowTerm (from Chantelle Verhey's list) has URLs for terms, and ARK IDs, but the ARKS don't dereference through the standard N2t.net resolver....

Issue77 temporal coverage

change gstime to gsqtime for NIs

This addresses issue #223, and pulls text from our decision document on namespace consistency. It complements the text in the Dataset.md guide, which now says the same thing but explains it differently.

mbjones · 2022-06-03T01:18:56Z

guides/Dataset.md

+        "time": "http://www.w3.org/2006/time#",
+        "xsd": "https://www.w3.org/TR/2004/REC-xmlschema-2-20041028/datatypes.html"
+    },
+    {


No brace needed here. And delete matching close brace below.

mbjones · 2022-06-03T01:19:11Z

guides/Dataset.md

+                }
+            }
+        }]</strong>
+    }


Delete brace

mbjones · 2022-06-03T01:19:34Z

guides/Dataset.md

+        "time": "http://www.w3.org/2006/time#",
+        "xsd": "https://www.w3.org/TR/200 (from [OWL Time](http://www.w3.org/2006/time))4/REC-xmlschema-2-20041028/datatypes.html"
+    },
+    {


Delete brace and close brace below.

mbjones · 2022-06-03T01:19:51Z

guides/Dataset.md

+        "time": "http://www.w3.org/2006/time#",
+        "xsd": "https://www.w3.org/TR/2004/REC-xmlschema-2-20041028/datatypes.html"
+    },
+    {


Delete brace and close brace below.

mbjones · 2022-06-03T01:20:14Z

guides/Dataset.md

+        "time": "http://www.w3.org/2006/time#",
+        "xsd": "https://www.w3.org/TR/2004/REC-xmlschema-2-20041028/datatypes.html"
+    },
+    {


Delete brace and close brace below.

mbjones · 2022-06-03T01:20:31Z

guides/Dataset.md

+        "ts": "http://resource.geosciml.org/vocabulary/timescale/",
+        "xsd": "https://www.w3.org/TR/2004/REC-xmlschema-2-20041028/datatypes.html"
+    },
+    {


Delete brace and close brace below.

Update namespace guidance to conform with http guideline.

Note that these problems occured due to extra braces that were present when moving the examples from the `@graph` based version in the example file into the markdown document. I checked them in the playground and they seem to work now.

mbjones

This review focuses on the new Temporal Coverage section, which looks good. My one request for change is that we eliminate the non-parseable and duplicated array entry that leads off each temporalCoverage array. As a duplicate, harvesters and other consumers do not need this information, and because it is not machine parseable, harvesters won't know how to deal with it and may end up not including temporal coverage in their search. Better to stick with machine parseable representations of temporal coverage, and only use multiple elements in the array when trying to express discontiguous temporalCoverage periods.

mbjones · 2022-06-03T19:33:47Z

guides/Dataset.md

+
+    "@type": "Dataset",
+        "description": "Eruptive activity at Mt. St. Helens, Washington, March 1980 - January 1981",
+<strong>        "temporalCoverage": ["1980-03-27T19:36:00/1981-01-03T00:00:00Z",


This temporal coverage duplicates the coverage information in the two elements of the array, using different syntax. This is not necessary and is confusing. As we are only illustrating here how time:ProperInterval works, I suggest the first entry should be deleted.

This problem is repeated in all 7 temporal coverage examples.

Suggested change

 "temporalCoverage": ["1980-03-27T19:36:00/1981-01-03T00:00:00Z",

 "temporalCoverage": [

@mbjones This change seems good to me. We discussed having a text field as one element in an array of temporalCoverage entries but we do have a human readable description for the age, so removing it for the reasons you stated makes sense. These changes also need to be made to the decision doc and the temporalCoverage.jsonld example file. I can do that by Tuesday night next week, if someone doesn't want to do it before then.

I was wondering if the array should be removed when there is only one element in the temporalCoverage array. Only example 6 has more than one element in the temporalCoverage array once these duplicate text entries are removed.

It would be fine to remove the array, or to leave it as a one-element array. I decided it was simpler to leave it.

mbjones · 2022-06-03T19:34:56Z

guides/Dataset.md

+    },
+    "@type": "Dataset",
+    "description": "Eruption of Bishop Tuff, about 760,000 years ago",
+    <strong>"temporalCoverage": ["760 ka",


Same duplication issue as before, but also this string is not machine parseable following the xsd syntax.

Suggested change

"temporalCoverage": ["760 ka",

"temporalCoverage": [

mbjones · 2022-06-03T19:35:36Z

guides/Dataset.md

+    },
+    "@type": "Dataset",
+    "description": "Very old zircons from the Jack Hills formation Australia 4.404 +- 0.008 Ga (2-sigma)",
+    <strong>"temporalCoverage": ["4.404 +/-+/- 0.008 Ga",


Same duplication issue, and not machine parseable.

Suggested change

"temporalCoverage": ["4.404 +/-+/- 0.008 Ga",

"temporalCoverage": [

mbjones · 2022-06-03T19:36:25Z

guides/Dataset.md

+    },
+    "@type": "Dataset",
+    "description": "Isotopic ages determined at the bottom and top of a stratigraphic section in the Columbia River Basalts",
+    <strong>"temporalCoverage": ["17.1 +/- 0.15 to 15.7 +/- 0.14 Ma",


Same duplication issue, and not machine parseable.

Suggested change

"temporalCoverage": ["17.1 +/- 0.15 to 15.7 +/- 0.14 Ma",

"temporalCoverage": [

mbjones · 2022-06-03T19:37:04Z

guides/Dataset.md

+    },
+    "@type": "Dataset",
+    "description": "Age of a piece of charcoal found in a burnt hut at an archeological site in Kenya carbon dated at BP Calibrated of 2640 +130 -80 (one-sigma) using the INTCAL20 carbon dating curve.",
+    <strong>"temporalCoverage": ["2640 +130 -80 BP-CAL (INTCAL20)",


Duplicated coverage, and not machine parseable.

Suggested change

"temporalCoverage": ["2640 +130 -80 BP-CAL (INTCAL20)",

"temporalCoverage": [

mbjones · 2022-06-03T19:38:08Z

guides/Dataset.md

+    },
+    "@type": "Dataset",
+    "description": "Temporal position expressed with a named time ordinal era from [International Chronostratigraphic Chart](https://stratigraphy.org/chart):",
+    <strong>"temporalCoverage": ["Bartonian",


Duplicated coverage, not machine parseable.

Suggested change

"temporalCoverage": ["Bartonian",

"temporalCoverage": [

mbjones · 2022-06-03T19:39:05Z

guides/Dataset.md

+    },
+    "@type": "Dataset",
+    "description": "Temporal position expressed with an interval bounded by named time ordinal eras from [International Chronostratigraphic Chart](https://stratigraphy.org/chart). NumericPositions not included, expect clients can lookup bounds for ISC nominal positions:",
+    <strong>"temporalCoverage": ["Triassic to Jurassic", {


Duplicated coverage, not machine parseable.

Suggested change

"temporalCoverage": ["Triassic to Jurassic", {

"temporalCoverage": [ {

…e array

Fixed formatting in examples

mbjones

During the SOSO Cluster call today on 2022-06-06, we reviewed the current proposed changes in the develop branch and voted unanimously to approve the 1.3 release and the endorsement document with the changes discussed during the call, which have now been made to both documents. So @ashepherd, we now have agreement across the group to merge develop to main and tag and release it. As the author of this PR, I can not approve it, but once @ashepherd or @datadavev or somebody approves it, we will be able to click merge.

ashepherd and others added 30 commits June 16, 2021 09:28

Merge pull request #171 from ESIPFed/feature_66_checksum

fb9d77c

convention for including `spdx:checksum` for objects

Merge pull request #165 from ESIPFed/feature_135_jsonld_keywords

b296b08

Feature 135 jsonld @list keyword

add tiers and advanced section in variable discussion

e9a8d88

Restructured intro to variables section.

24e353c

Merge pull request #173 from mbjones/issue27-forPullRequest

defdb2a

pull MBJones Restructured intro to variables section. into Issue27-forPullRequest branch

merge MBJones edites to measuredVariable discussion, move part of dis…

ba71fe2

…cussion to advanced section

start decision record for temporal coverage updates, with examples

506b14f

fix /2006/time# uris

a4352a9

link to hasTime in w3c document

f6bd921

note on ICS updates and citing a specific version

1297d9b

make it more clear that data repository guidance is for describing a …

e2e7d20

…data repository

Merge pull request #174 from njarboe/master

6c223c4

make it clearer that data repository guidance is for describing a repository, not where repositories should necessarily start.

Update Dataset.md

a445ebe

update dataset keywords diagrams

5ce4b40

update diagrams

21a4d6f

remove keywords from basic-fields diagram

7112ca7

altered one sentence for clarity

29698be

change "can not" to "cannot"

6698191

fixed typo

076ffe4

added examples to temporalCoverage

6aca66d

fixed typos and added unsymmtric uncertainty terms

f1f80d5

fix typo

a616132

update dataset guidance based on decision document

32289c1

DefinedTerm-change example dataset title and identifier encoding

da42cf0

fix formatting

405e8ce

use DefinedTerm for keywords

4d8f3ac

Merge pull request #183 from njarboe/Issue77-temporalCoverage

543461b

Issue77 temporal coverage

cleaned up json so ages have just the value

d3ca2a0

formatting fixes and link updates

8727525

ashepherd and others added 13 commits May 26, 2022 15:14

Delete dataset_geologic_time_2.svg

42b1359

update geologic time images

d4ca978

Merge branch 'develop' into Issue77-temporalCoverage

18d8911

Merge pull request #221 from ESIPFed/Issue77-temporalCoverage

167ed51

Issue77 temporal coverage

change gstime to gsqtime for NIs

d809fdc

changed text and link from geoschemas Named Individuals to properties

6d8b358

fixed spelling

6199cc2

clean up Geologic Time intro paragraph

6fa890c

minor text edit

a2f9ee6

Merge pull request #222 from ESIPFed/Issue77-temporalCoverage

94931bd

change gstime to gsqtime for NIs

Update namespace guidance to conform with http guideline.

ab8459d

This addresses issue #223, and pulls text from our decision document on namespace consistency. It complements the text in the Dataset.md guide, which now says the same thing but explains it differently.

Revisions based on feedback from @datadavev.

42033cc

Fix whitespace and indenting.

d2b4ec0

mbjones commented Jun 3, 2022

View reviewed changes

guides/Dataset.md Outdated

}

}

}]

}

Copy link

Collaborator Author

mbjones Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete brace

mbjones commented Jun 3, 2022

View reviewed changes

ashepherd and others added 3 commits June 2, 2022 22:46

Merge pull request #224 from ESIPFed/223-fix-namespace-in-conventions

9e26e7f

Update namespace guidance to conform with http guideline.

Reorder Dates section to be adjacent to TemporalCoverage section.

73e4e1f

Fix syntax errors in temporalCoverage examples.

c1dff11

Note that these problems occured due to extra braces that were present when moving the examples from the `@graph` based version in the example file into the markdown document. I checked them in the playground and they seem to work now.

mbjones commented Jun 3, 2022

View reviewed changes

njarboe added 3 commits June 3, 2022 18:07

Removed duplicate text entry at the beginning of each temporalCoverag…

95dc1b4

…e array

Remove non-machine readable items from the temporal coverage arrays

fa9a5b2

Update 77-temporalCoverageGuidance.md

88916c3

Fixed formatting in examples

mbjones commented Jun 6, 2022

View reviewed changes

ashepherd approved these changes Jun 7, 2022

View reviewed changes

ashepherd merged commit 4c956fa into master Jun 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

merge develop to create 1.3 release #207

merge develop to create 1.3 release #207

mbjones commented Apr 15, 2022

mbjones Jun 3, 2022

mbjones Jun 3, 2022

mbjones Jun 3, 2022

mbjones Jun 3, 2022

mbjones Jun 3, 2022

mbjones Jun 3, 2022

mbjones left a comment

mbjones Jun 3, 2022

njarboe Jun 3, 2022

njarboe Jun 4, 2022

mbjones Jun 4, 2022

mbjones Jun 3, 2022

mbjones Jun 3, 2022

mbjones Jun 3, 2022

mbjones Jun 3, 2022

mbjones Jun 3, 2022

mbjones Jun 3, 2022

mbjones left a comment

	<strong> "temporalCoverage": ["1980-03-27T19:36:00/1981-01-03T00:00:00Z",
	<strong> "temporalCoverage": [

	<strong>"temporalCoverage": ["760 ka",
	<strong>"temporalCoverage": [

	<strong>"temporalCoverage": ["4.404 +/-+/- 0.008 Ga",
	<strong>"temporalCoverage": [

	<strong>"temporalCoverage": ["17.1 +/- 0.15 to 15.7 +/- 0.14 Ma",
	<strong>"temporalCoverage": [

	<strong>"temporalCoverage": ["2640 +130 -80 BP-CAL (INTCAL20)",
	<strong>"temporalCoverage": [

	<strong>"temporalCoverage": ["Bartonian",
	<strong>"temporalCoverage": [

	<strong>"temporalCoverage": ["Triassic to Jurassic", {
	<strong>"temporalCoverage": [ {

merge develop to create 1.3 release #207

merge develop to create 1.3 release #207

Conversation

mbjones commented Apr 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbjones left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbjones left a comment

Choose a reason for hiding this comment