Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.8 #2053

Merged
merged 1 commit into from
May 24, 2023
Merged

Drop support for Python 3.8 #2053

merged 1 commit into from
May 24, 2023

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented May 23, 2023

Description

Drop support for Python 3.8 because NEP 29 recommends that we drop support for Python 3.8 on Apr 14, 2023.

Closes #1995


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the installation Installation problem label May 23, 2023
@bouweandela bouweandela added this to the v2.9.0 milestone May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #2053 (a9fe4c4) into main (64f7c0f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2053   +/-   ##
=======================================
  Coverage   92.79%   92.79%           
=======================================
  Files         236      236           
  Lines       12484    12484           
=======================================
  Hits        11585    11585           
  Misses        899      899           

@bouweandela bouweandela marked this pull request as ready for review May 23, 2023 10:32
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! I had a look about and couldn't find any more mentions of Python 3.8 - I reckon we good, man - cheers 🍺

@@ -77,7 +77,7 @@ jobs:
runs-on: "macos-latest"
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10"]
python-version: ["3.9", "3.10"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open a reminder issue to have 3.11 in here once we deploy, good reminder, dude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.8?
2 participants