Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 3.8 #2053

Merged
merged 1 commit into from
May 24, 2023
Merged

Drop support for Python 3.8 #2053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/install-from-conda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ name: Install from conda-forge

# runs on a push on main and at the end of every day
on:
# triggering on push without branch name will run tests everytime
# triggering on push without branch name will run tests every time
# there is a push on any branch
# turn it on only if needed
push:
branches:
- main
- main
# run the test only if the PR is to main
# turn it on if required
# pull_request:
Expand All @@ -35,9 +35,9 @@ jobs:
strategy:
matrix:
# TODO add "3.11" once we have the package built
python-version: ["3.8", "3.9", "3.10"]
python-version: ["3.9", "3.10"]
# fail-fast set to False allows all other tests
# in the worflow to run regardless of any fail
# in the workflow to run regardless of any fail
fail-fast: false
name: Linux Python ${{ matrix.python-version }}
steps:
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
runs-on: "macos-latest"
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10"]
python-version: ["3.9", "3.10"]
fail-fast: false
name: OSX Python ${{ matrix.python-version }}
steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/install-from-condalock-file.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ name: Conda-lock Install
on:
push:
branches:
- main
- main
# run the test only if the PR is to main
# turn it on if required
#pull_request:
Expand All @@ -24,7 +24,7 @@ jobs:
runs-on: "ubuntu-latest"
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.9", "3.10", "3.11"]
fail-fast: false
name: Linux Python ${{ matrix.python-version }}
steps:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/install-from-pypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
# turn it on only if needed
push:
branches:
- main
- main
# run the test only if the PR is to main
# turn it on if required
#pull_request:
Expand All @@ -35,7 +35,7 @@ jobs:
strategy:
matrix:
# TODO add "3.11" once we have the package built
python-version: ["3.8", "3.9", "3.10"]
python-version: ["3.9", "3.10"]
# fail-fast set to False allows all other tests
# in the workflow to run regardless of any fail
fail-fast: false
Expand Down Expand Up @@ -77,7 +77,7 @@ jobs:
runs-on: "macos-latest"
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10"]
python-version: ["3.9", "3.10"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open a reminder issue to have 3.11 in here once we deploy, good reminder, dude

fail-fast: false
name: OSX Python ${{ matrix.python-version }}
steps:
Expand All @@ -103,8 +103,8 @@ jobs:
run: pip install esmvalcore 2>&1 | tee pip_install_osx_artifacts_python_${{ matrix.python-version }}/install.txt
- name: Verify installation
shell: bash -l {0}
run: |
esmvaltool --help
run: |
esmvaltool --help
esmvaltool version 2>&1 | tee pip_install_osx_artifacts_python_${{ matrix.python-version }}/version.txt
- name: Upload artifacts
if: ${{ always() }} # upload artifacts even if fail
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/install-from-source.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ name: Install from Source

# runs on a push on main and at the end of every day
on:
# triggering on push without branch name will run tests everytime
# triggering on push without branch name will run tests every time
# there is a push on any branch
# turn it on only if needed
push:
branches:
- main
- main
# run the test only if the PR is to main
# turn it on if required
#pull_request:
Expand All @@ -32,7 +32,7 @@ jobs:
runs-on: "ubuntu-latest"
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.9", "3.10", "3.11"]
fail-fast: false
name: Linux Python ${{ matrix.python-version }}
steps:
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
runs-on: "macos-latest"
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.9", "3.10", "3.11"]
fail-fast: false
name: OSX Python ${{ matrix.python-version }}
steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/run-tests-comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: "ubuntu-latest"
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10"]
python-version: ["3.9", "3.10"]
fail-fast: false
name: Linux Python ${{ matrix.python-version }}
if: ${{ github.event.issue.pull_request && github.event.comment.body == '@runGAtests' }}
Expand Down Expand Up @@ -48,7 +48,7 @@ jobs:
runs-on: "macos-latest"
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10"]
python-version: ["3.9", "3.10"]
fail-fast: false
name: OSX Python ${{ matrix.python-version }}
if: ${{ github.event.issue.pull_request && github.event.comment.body == '@runGAtests' }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/run-tests-monitor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
runs-on: "ubuntu-latest"
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.9", "3.10", "3.11"]
fail-fast: false
name: Linux Python ${{ matrix.python-version }}
steps:
Expand Down Expand Up @@ -57,7 +57,7 @@ jobs:
runs-on: "macos-latest"
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.9", "3.10", "3.11"]
fail-fast: false
name: OSX Python ${{ matrix.python-version }}
steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
runs-on: "ubuntu-latest"
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.9", "3.10", "3.11"]
fail-fast: false
name: Linux Python ${{ matrix.python-version }}
steps:
Expand Down Expand Up @@ -72,7 +72,7 @@ jobs:
runs-on: "macos-latest"
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.9", "3.10", "3.11"]
fail-fast: false
name: OSX Python ${{ matrix.python-version }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ dependencies:
- psutil
- py-cordex
- pybtex
- python>=3.8
- python>=3.9
- python-stratify
- pyyaml
- requests
Expand Down
1 change: 0 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ def read_description(filename):
'Natural Language :: English',
'Operating System :: POSIX :: Linux',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',
Expand Down