obs4mips CERES-EBAF: update version to latest available through esgf in recipe_validation.yml #3002
Conversation
| @@ -48,7 +48,7 @@ diagnostics: | |||
| rsut: # TOA SW up all sky | |||
| preprocessor: pp_rad | |||
| additional_datasets: | |||
| - {dataset: CERES-EBAF, project: obs4MIPs, mip: Amon, level: L3B, version: Ed2-7, start_year: 2001, end_year: 2012, tier: 1} | |||
| - {dataset: CERES-EBAF, project: obs4MIPs, mip: Amon, level: L3B, version: v20160610, start_year: 2001, end_year: 2012, tier: 1} | |||
There was a problem hiding this comment.
Wouldn't it be simpler for maintenance purposes to remove the version of obs4MIPs datasets in cases like that? Otherwise, we would have to update the recipes every time an obs4MIPs dataset is retracted from ESGF.
| - {dataset: CERES-EBAF, project: obs4MIPs, mip: Amon, level: L3B, version: v20160610, start_year: 2001, end_year: 2012, tier: 1} | |
| - {dataset: CERES-EBAF, project: obs4MIPs, mip: Amon, level: L3B, start_year: 2001, end_year: 2012, tier: 1} |
There was a problem hiding this comment.
sounds good to me, man! I thought we ought to give it all the times, but really, I don't have obs4mips OCD 😁
There was a problem hiding this comment.
@remi-kazeroni In the future, I would propose to specify the version as much as possible for all datasets in all recipes. If a dataset is no longer publicly available the recipe is broken according to our policy because people cannot obtain the data and it should be dealt with according to that policy.
Co-authored-by: Rémi Kazeroni <70641264+remi-kazeroni@users.noreply.github.com>
|
Nope, it looks like the old behaviour is still in - |
This reverts commit c7d45af.
|
< version is a needed key Indeed, the default config-developer.yml of ESMValCore versions prior to the upcoming v2.8 uses the |
|
Cheers @bouweandela - indeed, I too feel a bit more comfortable specifying the version, even if this means a bit more recipe maintenance. @remi-kazeroni you mind merging this, bud? 🍺 |
|
Cheers @valeriupredoi and @bouweandela 🍻 |
Description
As @bouweandela explains the root cause of a data finding error in ESMValGroup/ESMValCore#1866 (comment) it proves out that the old version Ed2-7 is obsolete, and is not found on ESGF no more, hence I am updating it; I'd like to keep the version facet so things are clean and open.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic