Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obs4mips CERES-EBAF: update version to latest available through esgf in recipe_validation.yml #3002

Merged
merged 3 commits into from
Jan 19, 2023
Merged

obs4mips CERES-EBAF: update version to latest available through esgf in recipe_validation.yml #3002

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
901846b
update version to latest available through esgf
valeriupredoi Jan 10, 2023
c7d45af
Update esmvaltool/recipes/recipe_validation.yml
valeriupredoi Jan 11, 2023
ad23959
Revert "Update esmvaltool/recipes/recipe_validation.yml"
valeriupredoi Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion esmvaltool/recipes/recipe_validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ diagnostics:
rsut: # TOA SW up all sky
preprocessor: pp_rad
additional_datasets:
- {dataset: CERES-EBAF, project: obs4MIPs, mip: Amon, level: L3B, version: Ed2-7, start_year: 2001, end_year: 2012, tier: 1}
- {dataset: CERES-EBAF, project: obs4MIPs, mip: Amon, level: L3B, version: v20160610, start_year: 2001, end_year: 2012, tier: 1}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be simpler for maintenance purposes to remove the version of obs4MIPs datasets in cases like that? Otherwise, we would have to update the recipes every time an obs4MIPs dataset is retracted from ESGF.

Suggested change
- {dataset: CERES-EBAF, project: obs4MIPs, mip: Amon, level: L3B, version: v20160610, start_year: 2001, end_year: 2012, tier: 1}
- {dataset: CERES-EBAF, project: obs4MIPs, mip: Amon, level: L3B, start_year: 2001, end_year: 2012, tier: 1}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me, man! I thought we ought to give it all the times, but really, I don't have obs4mips OCD 😁

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remi-kazeroni In the future, I would propose to specify the version as much as possible for all datasets in all recipes. If a dataset is no longer publicly available the recipe is broken according to our policy because people cannot obtain the data and it should be dealt with according to that policy.

scripts:
lat_lon:
script: validation.py
Expand Down