New recipe and diagnostic for Arctic-midlatitude research #3021

egalytska · 2023-01-19T16:13:20Z

Description

This pull request provides a recipe and diagnostic to calculate variables that are further used by causal discovery. Selected variables represent major drivers of Arctic-midlatitude teleconnections. This will be a part of the Galytska et al manuscript.

No issue was opened
Link to documentation: https://esmvaltool--3021.org.readthedocs.build/en/3021/recipes/recipe_galytska23jgr.html

Before you get started

☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

🛠 This pull request has a descriptive title
🛠 Code is written according to the code quality guidelines
🛠 Documentation is available
🛠 Tests run successfully
🛠 The list of authors is up to date
🛠 Any changed dependencies have been added or removed correctly
🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

🧪 Recipe runs successfully
🧪 Recipe is well documented
🧪 Figure(s) and data look as expected from literature
🛠 Provenance information has been added

…rst draft for Galytska et al paper

…ased on data source

bsolino · 2023-02-13T16:24:22Z

Hi @egalytska!,
I've just started with the PR. I have noticed that the tests are failing because of some issues with the code standard. I have solved some of them automatically (using these commands), but there are still a few that can't be resolved that way:
./esmvaltool/diag_scripts/galytska22/select_actors_for_tigramite.py:5:1: F401 'numpy as np' imported but unused ./esmvaltool/diag_scripts/galytska22/select_actors_for_tigramite.py:14:1: F401 'esmvaltool.diag_scripts.shared.save_data' imported but unused ./esmvaltool/diag_scripts/galytska22/select_actors_for_tigramite.py:73:18: N806 variable 'psl_Ural' in function should be lowercase ./esmvaltool/diag_scripts/galytska22/select_actors_for_tigramite.py:76:18: N806 variable 'psl_Sib' in function should be lowercase ./esmvaltool/diag_scripts/galytska22/select_actors_for_tigramite.py:79:18: N806 variable 'psl_Aleut' in function should be lowercase ./esmvaltool/diag_scripts/galytska22/select_actors_for_tigramite.py:85:18: N806 variable 'sic_BK' in function should be lowercase ./esmvaltool/diag_scripts/galytska22/select_actors_for_tigramite.py:88:18: N806 variable 'sic_Ok' in function should be lowercase

You can find this information this below in the "ci/circleci: run_tests" and the "Codacy Static Code Analysis" details.

esmvaltool/utils/batch-jobs/job_DKRZ-EG.sh

config-user_EG_levante.yml

remi-kazeroni

Thanks for addressing all the previous points, @egalytska! I have 2 minor suggestions for you in order to get all green lights and proceed with the rest of the technical review :+1

esmvaltool/diag_scripts/galytska23/select_variables_for_tigramite.py

doc/sphinx/source/recipes/recipe_galytska23jgr.rst

Co-authored-by: Rémi Kazeroni <remi.kazeroni@dlr.de>

egalytska · 2023-06-16T12:52:42Z

Hi @remi-kazeroni, thanks for the comments.
I think I have addressed all the issues.

remi-kazeroni

@egalytska - Thanks a lot for your contribution and addressing the comments! All looks good to me from a technical point of view. The recipe runs fine and produces provenance records for the nc files. As the recipe needs to be run on a full compute node, I added an entry to generate.py.

@LisaBock - could you please have a final look for the scientific review, possibly on Monday? This way the PR could still make it in before feature freeze for v2.9 👍
If it helps, here is a path to a successful run: /work/bd0854/b309192/runs/tests/PR_3021/esmvaltool_output/recipe_galytska23jgr_20230616_133228

esmvaltool/diag_scripts/galytska23/select_variables_for_tigramite.py

…ite.py add referense Co-authored-by: Rémi Kazeroni <remi.kazeroni@dlr.de>

LisaBock

Thanks @egalytska for your work! Looks like all my comments are addressed.

schlunma · 2023-06-19T09:08:51Z

Thanks all 🚀

…old_and_clone_task_rtw * recipe_test_workflow_prototype: (199 commits) #3169: Upgrade the RTW to work with ESMValTool v2.8.0 [Condalock] Update Linux condalock file (#3237) Modified links to the tutorial (#3236) Add ESMValCore release `v2.8.1` into the documentation (#3235) Generate climatology on the fly for AutoAssess soil moisture (#3197) New recipe and diagnostic for Arctic-midlatitude research (#3021) Fixed pandas diagnostics for pandas>=2.0.0 (#3209) Update obs4MIPs dataset to the current naming scheme in recipe_smpi.yml (#2991) Add variable long names to provenance record in monitoring diagnostics (#3222) Extension of NASA MERRA2 CMORizer (cl, cli, clivi, clw, clwvi) (#3167) Remove "fx_variable" from recipe_wenzel14jgr.yml (#3212) [Condalock] Update Linux condalock file (#3217) Add Seaborn diagnostic (#3155) Remove fx_variables from ipccwg1ar5ch9 recipes (#3215) Remove "fx_variable" from recipe_tebaldi21esd.yml (#3211) Update recipe_impact.yml to work with newer versions of `pandas` (#3220) Use ESMValCore v2.9.0 release candidates (#3219) [Github Actions ] Check if python minor version changed after Julia install in development installation test (#3213) New plot_type 1d_profile in monitor (#3178) Add support for using a dask distributed scheduler (#3151) ...

Co-authored-by: Evgenia Galytska <b380971@levante3.atos.local> Co-authored-by: Evgenia Galytska <b380971@levante5.atos.local> Co-authored-by: Evgenia Galytska <b380971@levante4.atos.local> Co-authored-by: Brei Soliño <b.solinofernandez@gmail.com> Co-authored-by: Breixo Soliño <Breixo.SolinoFernandez@dlr.de> Co-authored-by: Rémi Kazeroni <remi.kazeroni@dlr.de> Co-authored-by: Lisa Bock <lisa.bock@dlr.de>

egalytska and others added 16 commits September 9, 2022 12:25

calculate actors for Arctic-midlat teleconnections

2836bc8

naming changes and recipe small improvement

d33012c

minor correction

9a7e396

correction

dc51404

corrected config file

d0d32f5

cvdp-related things

1b9be14

changed the path for diagnostics

0479f6b

remove old file

f13a147

modified config user file

d5477c7

recipe to define variables for Arctic-midlatitude teleconnections, fi…

7016535

…rst draft for Galytska et al paper

delete old file

a693c28

modified bash file to run esmvaltool

7d76a52

add python diagnostic to calculate variables and save into .nc file b…

a086dbc

…ased on data source

remove the old recipe, was used only for the tests

451b84f

remove an old recipy file that was used for the tests

a500871

added a path with cmorized HAdISST data

94d6e4c

egalytska requested review from remi-kazeroni and bsolino January 19, 2023 16:13

remi-kazeroni added the diagnostic label Jan 19, 2023

remi-kazeroni added this to the v2.8.0 milestone Jan 19, 2023

egalytska and others added 4 commits January 20, 2023 11:52

Merge branch 'main' into Arctic-midlat_EG

aad8e28

Merge branch 'main' into Arctic-midlat_EG

3384d5b

Merge branch 'main' into Arctic-midlat_EG

132269d

Automated code standards fixing

3831711

bsolino reviewed Feb 13, 2023

View reviewed changes

esmvaltool/utils/batch-jobs/job_DKRZ-EG.sh Outdated Show resolved Hide resolved

bsolino reviewed Feb 13, 2023

View reviewed changes

config-user_EG_levante.yml Outdated Show resolved Hide resolved

egalytska added 3 commits February 15, 2023 12:42

redundant file

bc54e16

redundant config-user file

829e3b4

updated folder name

f79b87b

egalytska added 3 commits June 15, 2023 11:18

Merge remote-tracking branch 'origin' into HEAD

8b6385f

code style fixes

61061d1

fix code style mistakes

f2a6cb6

egalytska marked this pull request as ready for review June 15, 2023 13:44

remi-kazeroni removed the requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request.. label Jun 16, 2023

egalytska added 4 commits June 16, 2023 10:29

fixing prospector issue

ee14e25

updated figure for the docs

e0bda0d

fix typo in end_year

b531f80

fix typo

865efc5

remi-kazeroni reviewed Jun 16, 2023

View reviewed changes

esmvaltool/diag_scripts/galytska23/select_variables_for_tigramite.py Outdated Show resolved Hide resolved

doc/sphinx/source/recipes/recipe_galytska23jgr.rst Outdated Show resolved Hide resolved

egalytska and others added 4 commits June 16, 2023 13:04

Update doc/sphinx/source/recipes/recipe_galytska23jgr.rst

1ecd3ad

Co-authored-by: Rémi Kazeroni <remi.kazeroni@dlr.de>

Merge branch 'main' into Arctic-midlat_EG

2c407cb

corrected issues with .nc files

93e2bb8

code stile fixes

619d274

egalytska and others added 2 commits June 16, 2023 15:33

Delete job_DKRZ-EG.sh

399d7cf

added recipe to list of resource intensive ones

265f040

remi-kazeroni approved these changes Jun 16, 2023

View reviewed changes

esmvaltool/diag_scripts/galytska23/select_variables_for_tigramite.py Outdated Show resolved Hide resolved

remi-kazeroni added approved by technical reviewer and removed in technical review labels Jun 16, 2023

Update esmvaltool/diag_scripts/galytska23/select_variables_for_tigram…

208b029

…ite.py add referense Co-authored-by: Rémi Kazeroni <remi.kazeroni@dlr.de>

LisaBock approved these changes Jun 19, 2023

View reviewed changes

remi-kazeroni added approved by scientific reviewer and removed in scientific review labels Jun 19, 2023

schlunma merged commit a9c8a26 into main Jun 19, 2023

schlunma deleted the Arctic-midlat_EG branch June 19, 2023 09:08

hb326 mentioned this pull request Jul 3, 2023

Add release notes for v2.9 #3266

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New recipe and diagnostic for Arctic-midlatitude research #3021

New recipe and diagnostic for Arctic-midlatitude research #3021

egalytska commented Jan 19, 2023 •

edited

Loading

bsolino commented Feb 13, 2023

remi-kazeroni left a comment

egalytska commented Jun 16, 2023

remi-kazeroni left a comment

LisaBock left a comment

schlunma commented Jun 19, 2023

New recipe and diagnostic for Arctic-midlatitude research #3021

New recipe and diagnostic for Arctic-midlatitude research #3021

Conversation

egalytska commented Jan 19, 2023 • edited Loading

Description

Before you get started

Checklist

New or updated recipe/diagnostic

bsolino commented Feb 13, 2023

remi-kazeroni left a comment

Choose a reason for hiding this comment

egalytska commented Jun 16, 2023

remi-kazeroni left a comment

Choose a reason for hiding this comment

LisaBock left a comment

Choose a reason for hiding this comment

schlunma commented Jun 19, 2023

egalytska commented Jan 19, 2023 •

edited

Loading