[Github Actions ] Check if python minor version changed after Julia install in development installation test #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why you laughing @bouweandela - in the words of Joe Pesci in Goodfellas: you think I'm funny? Do I amuse you? 😆 |
valeriupredoi
changed the title
bouweandela
reviewed
Jun 8, 2023
|
Thanks for putting this up @valeriupredoi! I was laughing because it's such a weird thing. I hope it was just a fluke with my |
|
cheers, bud, I know right? But hey - if you've seen it once (and no hefeweizens involved 😁 ) then one better check for it 👍 |
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
|
OK @bouweandela all works as expected, ready to launch 🚀 |
|
much cheers, bud 🍺 |
ehogan
added a commit
that referenced
this pull request
Jun 26, 2023
…old_and_clone_task_rtw * recipe_test_workflow_prototype: (199 commits) #3169: Upgrade the RTW to work with ESMValTool v2.8.0 [Condalock] Update Linux condalock file (#3237) Modified links to the tutorial (#3236) Add ESMValCore release `v2.8.1` into the documentation (#3235) Generate climatology on the fly for AutoAssess soil moisture (#3197) New recipe and diagnostic for Arctic-midlatitude research (#3021) Fixed pandas diagnostics for pandas>=2.0.0 (#3209) Update obs4MIPs dataset to the current naming scheme in recipe_smpi.yml (#2991) Add variable long names to provenance record in monitoring diagnostics (#3222) Extension of NASA MERRA2 CMORizer (cl, cli, clivi, clw, clwvi) (#3167) Remove "fx_variable" from recipe_wenzel14jgr.yml (#3212) [Condalock] Update Linux condalock file (#3217) Add Seaborn diagnostic (#3155) Remove fx_variables from ipccwg1ar5ch9 recipes (#3215) Remove "fx_variable" from recipe_tebaldi21esd.yml (#3211) Update recipe_impact.yml to work with newer versions of `pandas` (#3220) Use ESMValCore v2.9.0 release candidates (#3219) [Github Actions ] Check if python minor version changed after Julia install in development installation test (#3213) New plot_type 1d_profile in monitor (#3178) Add support for using a dask distributed scheduler (#3151) ...
jvegreg
pushed a commit
that referenced
this pull request
Jan 14, 2024
…nstall in development installation test (#3213) Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was prompted by @bouweandela telling me the Python minor version changed for a dev install case for him, from 11 to 10, yesterday, on Levante, after Julia installation with
esmvaltool install Julia. This should never happen since the Julia install should never alter core dependencies, especially pinned Python version, but heyho - I thought it's a good idea to plop a sanity check just in case.See the case when it doesn't change and the case when it still doesn't change but I force the reverse test to see if the implementation works as expected.
My apologies for the fair number of commits to this PR, I didn't know how to do it proper at the start of messing about 😁
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.