Build Zokrates in Dockerfile #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyasRidhuan
requested review from
Westlad,
ChaitanyaKonda,
LijuJoseJJ and
MirandaWood
IlyasRidhuan
force-pushed
the
ilyas/zokrates-source
branch
from
48e38a8
to
1483a4a
Compare
Merged
|
I made a PR #428 that tweaks this build to creat a zokrates container image, from which the binary is copied. Saves about 10 mins on my machine because the binary is only built once |
Westlad
approved these changes
Jan 27, 2022
|
My PR breaks the wallet tests so maybe leave it for now. |
|
It's not clear to me why it is breaking the tests though.. I experienced the same thing with this PR so I have re-run the workflow just in case |
|
ooh - it works now. Must be a timing thing. @druiz0992 has changed the timing in the wallet tests in PR #429 so hopefully this is a temporary issue and will go away when the ping-pong tests are merged. |
IlyasRidhuan
added
the
One more approval needed
IlyasRidhuan
force-pushed
the
ilyas/zokrates-source
branch
from
84a5b12
to
b382041
Compare
IlyasRidhuan
force-pushed
the
ilyas/zokrates-source
branch
from
b382041
to
0fc2ade
Compare
ChaitanyaKonda
approved these changes
Feb 7, 2022
|
🎉 This PR is included in version 1.15.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #399 and superseded #396.
Zokrates 0.7.10 is now directly built in
optimistandworkercontainers. This is achieved by using the rust image in the first build stage and cloning the appropriate Zokrates release.There is a constraint when compiling rust binaries; in particular, glibc is dynamically linked at compile time and the binary expects to have the same version of glibc when the binary is compiled and when it is run. As we require a slightly later version of rust to compile Zokrates successfully for ARM, we also need an image in stage 2 of the build that has a later version of glibc - the result is the following:
optimistwe use a later version of the mongo image (based on ubuntufocal- 20.04).worker, I'm hesitant to bump the node version past node@14, so instead we pull in the ubuntu:20.04 image and install node@14. This does lead to a slightly larger final image, but if that becomes a future issue we can use a slimmer version oralpine.Finally, after Zokrates 0.7.9, the
--lightflag has been removed from thecompilecommand as it is now default behaviour. It has been removed.