Increased timings #429
Merged
Increased timings #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a block is submitted, now clients may wait up to 12 blocks for confirmation. This has an impact on wallet transaction tests, which expected results much earlier.
Additionally, i have seen that when launching
./start-nightfall -wt -s(running wallet tests), nightfall-client used to timed out waiting for some contract to be deployed. I have increased RETRIEs from 50 to 80.Also, i have seen that wallet tests could start before all contracts were deployed. I have added a new synchronization mechanism to prevent this from happening.
Finally, in order to provide simpler debugging with wallet tests, i now display information about proposer and liquidity provider.