remove secrets from deploy script #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westlad
requested review from
IlyasRidhuan,
signorecello,
ChaitanyaKonda,
druiz0992,
daveroga and
luizoamorim
ChaitanyaKonda
approved these changes
Feb 14, 2022
ChaitanyaKonda
added
the
One more approval needed
|
Wallet tests are being removed in #490 because they are part of legacy code. |
daveroga
approved these changes
Feb 28, 2022
ChaitanyaKonda
removed
the
One more approval needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dev environment deploy script contains Ropsten private keys. Although these are only for test purposes, it is better practice to create them as GitHub secrets and inject them into the script at deployment, because one day they may be real keys.
It's not possible to test fully without a deployment and so that will need to wait until we do a deploy to dev. However it's a fairly small change so I don't anticipate problems. If it fails, we can push a fix then.