Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove secrets from deploy script #493

Merged
merged 1 commit into from
Feb 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/development-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Add secret environment variables
run: |
echo "ETH_PRIVATE_KEY=${{ secrets.ETH_PRIVATE_KEY }}" >> deployment-scripts/dev.env
echo "PROPOSER_ETHEREUM_SIGNING_KEY=${{ secrets.PROPOSER_ETHEREUM_SIGNING_KEY }}" >> deployment-scripts/dev.env
- name: Configure SSH
run: |
mkdir -p ~/.ssh/
Expand Down
3 changes: 1 addition & 2 deletions deployment-scripts/dev.env
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ BLOCKCHAIN_WS_HOST=ropsten1-ws.testnet.nightfall3.com
BLOCKCHAIN_PORT=80
AUTOSTART_RETRIES=10000
ETH_NETWORK=ropsten
ETH_PRIVATE_KEY=abf4ed9f30bd1e4a290310d726c7bbdf39cd75a25eebd9a3a4874e10b4a0c4ce
ETH_ADDRESS='0xdb080dC48961bC1D67a0A4151572eCb824cC76E8'
TRANSACTIONS_PER_BLOCK=2
PROPOSER_ETHEREUM_SIGNING_KEY=645ac79fa9fd87dd1cf30bdca51d326bd501cd328d6dbc9f5f517c7da0dafa6f
# Other variables may be added here from GitHub secrets during deployment