feat: adding a restriction to proposers and challenger 🤌 #550
Conversation
signorecello
requested review from
Westlad,
ChaitanyaKonda,
druiz0992 and
daveroga
signorecello
force-pushed
the
zepedro/restrict-proposers
branch
from
ab0b9f3
to
f3421b7
Compare
| _; | ||
| } | ||
|
|
||
| function setBootProposer(address proposer) external onlyOwner { |
There was a problem hiding this comment.
With this approach we can only have one challenger and one proposer address, unless I've misunderstood. Whilst, initially we want to restrict who can propose and who can challenge, I can image that quite early on we would want to add additional proposers and challengers, if only for resilience (e.g. to guard against a proposer running out of money or getting banned). We can of course upgrade the contract to make such a change but would it be good to start with a mapping of allowed proposers and challengers, so that the owner can add and remove them?
There was a problem hiding this comment.
Well I agree with you, but I think the next step will be to just remove all this, as we're definitely only gonna have one proposer and challenger. But I'll tag @ChaitanyaKonda to decide if it's worth to make it a mapping or if we can leave it as just one proposer and challenger
I know this one will conflict with #527 but I guess that's a problem for my future self
Closes #541
I also removed some duplicate stuff in config, moved them to reference TEST_OPTIONS