-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding a restriction to proposers and challenger 🤌 #550
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
53e8c77
feat: adding a restriction to proposers and challenger 🤌
signorecello b3354bf
Merge remote-tracking branch 'origin' into zepedro/restrict-proposers
signorecello 32b2993
fix: fixing future self problem... merging
signorecello f3421b7
fix: fixing future self problem... merging
signorecello 4a8056f
fix: adding correct bootChallenger, adding back a bit of code lost in…
signorecello 032c478
wip
signorecello 12f4ea7
wip
signorecello 9800aac
Merge remote-tracking branch 'origin' into zepedro/restrict-proposers
signorecello 7603d14
wip
signorecello 4e50a79
fix: cant believe we simply werent giving bootproposer some fake cash
signorecello 675e043
fix: fixing ping-pong test and normalizing some configs
signorecello a97e15b
fix: fixing e2e tests
signorecello d29e112
fix: merge
signorecello d32955b
fix: merge
signorecello File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this approach we can only have one challenger and one proposer address, unless I've misunderstood. Whilst, initially we want to restrict who can propose and who can challenge, I can image that quite early on we would want to add additional proposers and challengers, if only for resilience (e.g. to guard against a proposer running out of money or getting banned). We can of course upgrade the contract to make such a change but would it be good to start with a mapping of allowed proposers and challengers, so that the owner can add and remove them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I agree with you, but I think the next step will be to just remove all this, as we're definitely only gonna have one proposer and challenger. But I'll tag @ChaitanyaKonda to decide if it's worth to make it a mapping or if we can leave it as just one proposer and challenger