112 bit transaction value to enable full 18 decimal place range with large integer part #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westlad
force-pushed
the
westlad/decimals-struct
branch
from
c1acb5d
to
5e1cb62
Compare
Westlad
changed the title
Westlad
force-pushed
the
westlad/decimals-struct
branch
from
02ec49d
to
2c21ca2
Compare
Westlad
changed the title
Westlad
requested review from
signorecello,
druiz0992,
daveroga and
ChaitanyaKonda
and removed request for
IlyasRidhuan
ChaitanyaKonda
approved these changes
Apr 21, 2022
ChaitanyaKonda
added
the
One more approval needed
druiz0992
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #607. It changes the dynamic range of a L2 transaction value to 112 bits, which can accommodate 18 decimal places with a 10^15 max value. The current 64 bit value is too small