-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Luizoamorim/integration #624
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web integration
@IlyasRidhuan I refactored the alignment, responsiveness and the local of nightfall address in wallet page. Have some more stuff that I forgot? |
luizoamorim
force-pushed
the
luizoamorim/559-assets-send-modal
branch
from
April 28, 2022 12:39
a1c660f
to
47a4b19
Compare
Closed in favour of #638 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This last branch I finalized with help of Ujjwal from Polygon.
Now we're using webpack (wallet/config) to generate the build folder. For that we have some scripts in a script folder (wallet/scripts) for run start and build commands.
These scripts run based on webpack.config file seetings.
I changed the build path from:
to:
It was asked by polygon wallet team.
As a result the build:integration in package.json was chaged also passing a PUBLIC_URL:
To test the integration locally:
Just run:
Open the URL generated by http-server, and execute the integration.html file i.e:
It will use our application like a web component
Also you can test it in dev mode running npm start.