Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Luizoamorim/integration #624

Closed
wants to merge 392 commits into from
Closed

Conversation

luizoamorim
Copy link
Contributor

@luizoamorim luizoamorim commented Apr 20, 2022

This last branch I finalized with help of Ujjwal from Polygon.
Now we're using webpack (wallet/config) to generate the build folder. For that we have some scripts in a script folder (wallet/scripts) for run start and build commands.
These scripts run based on webpack.config file seetings.

I changed the build path from:

const buildPath = process.env.BUILD_PATH || 'build';

to:

const buildPath = process.env.BUILD_PATH || 'build/nightfall';

It was asked by polygon wallet team.

As a result the build:integration in package.json was chaged also passing a PUBLIC_URL:

"build:integration": "LOCAL_PROPOSER=false USE_STUBS=false MODE=testnet PUBLIC_URL='/nightfall/' node scripts/build.js",

To test the integration locally:

Just run:

npm run build:integration
cd build
npm i -g http-server
http-server

Open the URL generated by http-server, and execute the integration.html file i.e:

localhost:8888/integration.html

It will use our application like a web component

Also you can test it in dev mode running npm start.

@luizoamorim
Copy link
Contributor Author

@IlyasRidhuan I refactored the alignment, responsiveness and the local of nightfall address in wallet page. Have some more stuff that I forgot?

@IlyasRidhuan
Copy link
Contributor

Closed in favour of #638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants