forked from facebook/react
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor[scripts/prettier]: respect .prettierignore when resolving js…
… files via glob (facebook#27627) This script is used on CI in `yarn_lint` job. With current `glob` call settings, it includes a bunch of build files, which are actually ignored by listing them in `.prettierignore`. This check is not failing only because there is no build step before it. If you run `node ./scripts/prettier/index` with build files present, you will see a bunch of files listed as non-formatted. These changes add a simple logic to include all paths listed in `.prettierignore` to ignore list of `glob` call with transforming them from gitignore-style to glob-style. This should unblock CI for facebook#27612, where `flow-typed` directory will be added, turned out that including it in `.prettierignore` is not enough.
- Loading branch information
1 parent
1ab3975
commit c1c26a3
Showing
2 changed files
with
33 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,14 @@ | ||
build | ||
|
||
packages/react-devtools-core/dist | ||
packages/react-devtools-extensions/chrome/build | ||
packages/react-devtools-extensions/firefox/build | ||
packages/react-devtools-extensions/edge/build | ||
packages/react-devtools-extensions/shared/build | ||
packages/react-devtools-extensions/src/ErrorTesterCompiled.js | ||
packages/react-devtools-inline/dist | ||
packages/react-devtools-shared/src/hooks/__tests__/__source__/__compiled__/ | ||
packages/react-devtools-shared/src/hooks/__tests__/__source__/__untransformed__/ | ||
packages/react-devtools-shell/dist | ||
packages/react-devtools-timeline/dist | ||
packages/react-devtools-timeline/static | ||
packages/react-devtools-timeline/static |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters