refactor[scripts/prettier]: respect .prettierignore when resolving js files via glob #27627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
hoxyq
force-pushed
the
consider-prettierignore-in-prettier-lint
branch
from
5f3b5b3
to
44b3db5
Compare
|
Comparing: 3e09c27...44b3db5 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
noahlemen
approved these changes
Oct 30, 2023
gnoff
added a commit
to gnoff/next.js
that referenced
this pull request
Oct 30, 2023
Successfully updated React from 8c8ee9ee6 to 0c6348758. - facebook/react#27627 - facebook/react#27624 - facebook/react#27610 - facebook/react#27592 - facebook/react#27593 - facebook/react#27588 - facebook/react#27591 - facebook/react#27587
ijjk
pushed a commit
to vercel/next.js
that referenced
this pull request
Oct 30, 2023
Update React from 8c8ee9ee6 to 0c6348758 - facebook/react#27627 - facebook/react#27624 - facebook/react#27610 - facebook/react#27592 - facebook/react#27593 - facebook/react#27588 - facebook/react#27591 - facebook/react#27587 Update @types/react to 18.2.33 Update @types/react-dom to 18.2.14
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
… files via glob (facebook#27627) This script is used on CI in `yarn_lint` job. With current `glob` call settings, it includes a bunch of build files, which are actually ignored by listing them in `.prettierignore`. This check is not failing only because there is no build step before it. If you run `node ./scripts/prettier/index` with build files present, you will see a bunch of files listed as non-formatted. These changes add a simple logic to include all paths listed in `.prettierignore` to ignore list of `glob` call with transforming them from gitignore-style to glob-style. This should unblock CI for facebook#27612, where `flow-typed` directory will be added, turned out that including it in `.prettierignore` is not enough.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
… files via glob (#27627) This script is used on CI in `yarn_lint` job. With current `glob` call settings, it includes a bunch of build files, which are actually ignored by listing them in `.prettierignore`. This check is not failing only because there is no build step before it. If you run `node ./scripts/prettier/index` with build files present, you will see a bunch of files listed as non-formatted. These changes add a simple logic to include all paths listed in `.prettierignore` to ignore list of `glob` call with transforming them from gitignore-style to glob-style. This should unblock CI for #27612, where `flow-typed` directory will be added, turned out that including it in `.prettierignore` is not enough. DiffTrain build for commit 0c63487.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script is used on CI in
yarn_lintjob. With currentglobcall settings, it includes a bunch of build files, which are actually ignored by listing them in.prettierignore. This check is not failing only because there is no build step before it.If you run
node ./scripts/prettier/indexwith build files present, you will see a bunch of files listed as non-formatted. These changes add a simple logic to include all paths listed in.prettierignoreto ignore list ofglobcall with transforming them from gitignore-style to glob-style.This should unblock CI for #27612, where
flow-typeddirectory will be added, turned out that including it in.prettierignoreis not enough.