Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup build-and-test.sh #11

Closed
nadinekuo opened this issue Oct 19, 2022 · 0 comments
Closed

cleanup build-and-test.sh #11

nadinekuo opened this issue Oct 19, 2022 · 0 comments
Assignees
@nadinekuo @Hrishikesh-Kalyanaraman

Comments

@nadinekuo
Copy link
Collaborator

nadinekuo commented Oct 19, 2022 •
edited
Loading

Make the build and test script more maintainable, i.e. easier to use by future developers

  • No sed (stream editor) to make changes to files from remote repository in Bitbucket ("spaghetti dependency"), but instead copy the files that are needed
  • Make the changes to the copied files and commit these changes
@nadinekuo nadinekuo mentioned this issue Dec 2, 2022
Merged
einsteintoolkit-updater pushed a commit that referenced this issue Sep 20, 2024
updated submodules
6d65e95 
Submodule repos/GRHayL dfd28bf..372f31a:
  > Merge pull request #69 from GRHayL/error_codes
Submodule repos/GRHayLET f9bacc4..1417c1a:
  > fixes to match error reporting improvements in GRHayL (#11)
nadinekuo pushed a commit to nadinekuo/einstein-toolkit-tests that referenced this issue Nov 7, 2024
updated submodules
f645b17 
Submodule repos/Scalar 8dbcb66..06b6062:
  > Merged in Fix_TwoPunctures_BBHSF_doc (pull request EinsteinToolkit#11)
einsteintoolkit-updater pushed a commit that referenced this issue Nov 7, 2024
updated submodules
8de45e2 
Submodule repos/Scalar 8dbcb66...06b6062:
  > Merged in Fix_TwoPunctures_BBHSF_doc (pull request #11)
  < Merged in Fix_TwoPunctures_BBHSF_Incompatible_Pointer_Types (pull request #7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadinekuo nadinekuo

@Hrishikesh-Kalyanaraman Hrishikesh-Kalyanaraman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nadinekuo @Hrishikesh-Kalyanaraman