Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare to changes made for carpetx-tests and merge "good" changes #7

Closed
rhaas80 opened this issue Oct 12, 2022 · 2 comments
Closed
Assignees

Comments

@rhaas80
Copy link
Member

rhaas80 commented Oct 12, 2022

Roland created a cut down version of the scripts (less spaghetti code as well) in https://github.com/EinsteinToolkit/carpetx-tests and some of the changes should / could be ported back. Eventually we would like to end up with a single set of scripts useful for all projects.

@nadinekuo
Copy link
Collaborator

nadinekuo commented Oct 19, 2022

No copying around of files (using cp), but operate directly in the original location of the file that is operated on (repository e.g.), for example:

- name: 'Checkout docs branch'
  uses: actions/checkout@v3
    with:
      ref: gh-pages
- name: 'Fetch master branch and checkout/copy over only the docs folder to gh-pages'
  run: |
    git fetch origin master --depth 1
    git checkout origin/master --no-overlay -- docs

from actions/checkout#578

You can pass (3) arguments to logpage.py indicating where it can find each file (i.e. the directory under $GITHUB_WORKSPACE, defined by the path)
2 arguments may be sufficient, since logpage.py can find out where it is located (master).

@nadinekuo
Copy link
Collaborator

It may be nice to rely on GitHub instead of external dependencies for checking concurrency, for example:

concurrency:
  group: carpetx
  cancel-in-progress: false

nadinekuo pushed a commit to nadinekuo/einstein-toolkit-tests that referenced this issue Jun 20, 2024
Submodule repos/Scalar 35bba04..8dbcb66:
  > Merged in Fix_TwoPunctures_BBHSF_Incompatible_Pointer_Types (pull request EinsteinToolkit#7)
einsteintoolkit-updater pushed a commit that referenced this issue Jun 20, 2024
Submodule repos/Scalar 35bba04..8dbcb66:
  > Merged in Fix_TwoPunctures_BBHSF_Incompatible_Pointer_Types (pull request #7)
einsteintoolkit-updater pushed a commit that referenced this issue Nov 7, 2024
Submodule repos/Scalar 8dbcb66...06b6062:
  > Merged in Fix_TwoPunctures_BBHSF_doc (pull request #11)
  < Merged in Fix_TwoPunctures_BBHSF_Incompatible_Pointer_Types (pull request #7)
nadinekuo pushed a commit to nadinekuo/einstein-toolkit-tests that referenced this issue Nov 20, 2024
Submodule repos/Proca 93f7a48..79d9ee2:
  > Merged in development (pull request EinsteinToolkit#7)
einsteintoolkit-updater pushed a commit that referenced this issue Nov 20, 2024
Submodule repos/Proca 93f7a48..79d9ee2:
  > Merged in development (pull request #7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants