🪂 Disable drag_to_scroll on frame selection ScrollArea
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm seems CI is hitting some unrelated linting errors, what should I do with those? |
3 tasks
emilk
pushed a commit
that referenced
this pull request
May 17, 2024
### Checklist * [x] I have read the [Contributor Guide](../CONTRIBUTING.md) * [x] I have read and agree to the [Code of Conduct](../CODE_OF_CONDUCT.md) * [x] I have added a description of my changes and why I'd like them included in the section below ### Description of Changes This PR cancels the revert (#208) of egui 0.27.1 update (#201) and fix the flamegraph interaction bug it introduced whenever the flamegraph's scroll area was active. ### Related Issues * Closes #207 * Closes #205
3 tasks
Hoodad
pushed a commit
that referenced
this pull request
Jun 28, 2024
Redo of #207 ### Checklist * [x] I have read the [Contributor Guide](../CONTRIBUTING.md) * [x] I have read and agree to the [Code of Conduct](../CODE_OF_CONDUCT.md) * [x] I have added a description of my changes and why I'd like them included in the section below ### Description of Changes In the version `0.27` release of `egui`, the interaction handling was changed. This caused the scope selection in the flamegraph to be unselectable. By disabling the `drag_to_scroll` on the related `ScrollArea` this issue is solved. The latest scope selection does not suffer from this, as it does not use a `ScrollArea`. Note that this does not have any behavioral effect, but instead results in the same behavior of click/drag/scroll when on egui `0.26`! ### Related Issues - Fixes #205 ```[tasklist] ### Tested on - [x] Windows - [x] Linux - [x] Mac - [x] Android ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
In the version
0.27release ofegui, the interaction handling was changed. This caused the frame selection in the frame graph to be unselectable. By disabling thedrag_to_scrollon the relatedScrollAreathis issue is solved.The latest frame selection does not suffer from this, as it does not use a
ScrollArea.Related Issues
puffin-egui: Incorrect flamegraph frame selection input handling #205