Fix broken flamegraph interaction with egui 0.27.1 #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this on Windows and MacOs, in neither case the issues described in #205 are solved. |
|
I guess I misread the comment… well, this fixed all the problems I could find |
My bad, I should've phrased it better. I'll see what I can find! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
This PR cancels the revert (#208) of egui 0.27.1 update (#201) and fix the flamegraph interaction bug it introduced whenever the flamegraph's scroll area was active.
Related Issues
drag_to_scrollon frame selectionScrollArea#207puffin-egui: Incorrect flamegraph frame selection input handling #205