Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spirv-tools #928

Merged
merged 6 commits into from
Oct 28, 2022
Merged

Update spirv-tools #928

merged 6 commits into from
Oct 28, 2022

Conversation

Jake-Shadle
Copy link
Member

@Jake-Shadle Jake-Shadle commented Oct 17, 2022

  • Update spirv-tools
  • Update spirv-tools installs to latest-ish

Updates spirv-tools to 2022.4 (and 2022.3 and 2022.2 because I have been slacking).


EDIT(@eddyb): marked as draft after rebasing onto (and blocking on):

@eddyb

This comment was marked as resolved.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@eddyb
Copy link
Contributor

eddyb commented Oct 24, 2022

Now that the whole deal in #928 (comment) has been fixed, I've bumped the spirv-tools version further so we should get better errors on CI now.


Also moving #928 (comment) here to be able to hide it:

Hah, you bumped all of these by 116 CI builds, so they are in lock-step, just with an offset from their initial setup at the very start? We could use that to our advantage and write a script that finds a set of 3 for a specific date - once we have e.g. the macOS CI build ID, we can derive the others from it and query the bucket for e.g. ".../${macos_id - 12}/${date}-*/install.tgz".

It's a bit messy but as long as we can do 3-4 curl requests in CI we can avoid hardcoding anything more than that one CI build ID (and even that we might be able to derive from the date if it's a reliably-daily build...).

(i.e. I thought maybe we could automate it - however it is annoying to do this on 3 different platforms when I only trust one of them to have the right tools for quickly script this, without e.g. reaching for Python)

@eddyb

This comment was marked as resolved.

@eddyb eddyb marked this pull request as ready for review October 27, 2022 09:13
@eddyb
Copy link
Contributor

eddyb commented Oct 28, 2022

I talked to @Jake-Shadle and there's some good ideas around moving away from this model to something that both avoids so many builds of the C++ code and avoids dealing with potentially-wildly-different system-installed tooling. (At the very least the system-installed mode could move to linking against the .a libraries, which could then be switched from "weird GCP CI artifacts bucket" to our own builds)

For now I want to merge this for the test fixes (when using system-installed SPIRV-Tools on other branches).

@eddyb eddyb merged commit fbc20c2 into main Oct 28, 2022
@eddyb eddyb deleted the update/spirv branch October 28, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants