-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update spirv-tools #928
Update spirv-tools #928
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Now that the whole deal in #928 (comment) has been fixed, I've bumped the Also moving #928 (comment) here to be able to hide it:
(i.e. I thought maybe we could automate it - however it is annoying to do this on 3 different platforms when I only trust one of them to have the right tools for quickly script this, without e.g. reaching for Python) |
This comment was marked as resolved.
This comment was marked as resolved.
I talked to @Jake-Shadle and there's some good ideas around moving away from this model to something that both avoids so many builds of the C++ code and avoids dealing with potentially-wildly-different system-installed tooling. (At the very least the system-installed mode could move to linking against the For now I want to merge this for the test fixes (when using system-installed SPIRV-Tools on other branches). |
Updates spirv-tools to 2022.4 (and 2022.3 and 2022.2 because I have been slacking).
EDIT(@eddyb): marked as draft after rebasing onto (and blocking on):attr: fix#[spirv(flat)]
checking to match the Vulkan spec. #933