attr: fix #[spirv(flat)]
checking to match the Vulkan spec.
#933
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust-GPU validation for
#[spirv(flat)]
was added in #815 but it had both:bool
s)The Vulkan spec validation rules relevant here are:
VUID-StandaloneSpirv-Flat-04670
VUID-StandaloneSpirv-Flat-04744
VUID-StandaloneSpirv-Flat-06201
VUID-StandaloneSpirv-Flat-06202
This was prompted by
spirv-val
improving their own checks (blocking updating SPIRV-Tools in #928):