Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Plotly Version for 'texttemplate' and Other Features #176

Closed
Gamma169 opened this issue Nov 6, 2020 · 5 comments · Fixed by #177
Closed

Upgrade Plotly Version for 'texttemplate' and Other Features #176

Gamma169 opened this issue Nov 6, 2020 · 5 comments · Fixed by #177

Comments

@Gamma169
Copy link

Gamma169 commented Nov 6, 2020

Hello! I notice that this package is running a slightly older version of plotly. Version 1.49.5
https://github.com/EmberMN/ember-cli-plotly/blob/master/package.json#L40

As of this issue, plotly is on version 1.57.1

I notice there is a pull request open that is upgrading plotly to the correct version.
#153

I am trying to use the texttemplate functionality implemented in plotly 1.50.0 (the release DIRECTLY after the 1.49.5 release that this package is currently using). I'm hoping that you can merge the plotly upgrade PR so that we can use the latest version of plotly instead of running off a commit.

@jacobq
Copy link
Member

jacobq commented Nov 6, 2020

O hai :octocat: I didn't realize anyone else was using this, so thank you for the reminder. (I think I was managing the plotly version via yarn resolutions in my apps that use this addon.) I haven't been paying much attention to this repository for a while, and it could use some freshening up for sure. I just ran ember-cli-update, ncu -u, yarn, and yarn upgrade over on PR #177. If its builds OK I'll release as v0.6.0 (wonderful thing about v0.x is that it can go 💥 right? 😉 )

@Gamma169
Copy link
Author

Gamma169 commented Nov 9, 2020

I am part of a team managing a production application with clients paying big bucks for a platform heavily reliant on plotly graphs and this library to a degree, ha ha. We've mostly been using the basic graph functionality, but now we want some more fancy stuff, so we ran into the issue.

Thanks for responding so quickly! I'll also take a look and see if I can help as well. I saw your PR, and maybe I can help with the travis issues too. Otherwise, your plan seems good to me. :)

@jacobq
Copy link
Member

jacobq commented Nov 11, 2020

My mass-update commit evidently broke a few things. I'll try to make some time yet this week to fix it up and release, but if you have time feel free to chime in regarding how to resolve the problems that showed up in CI like this one: https://travis-ci.org/github/EmberMN/ember-cli-plotly/jobs/741976878#L284-L311 (looks like somehow some node stuff is getting pulled into the final output, which obviously won't work when targeting a browser; see also embroider-build/ember-auto-import#126)

@Gamma169
Copy link
Author

Hi. Sorry for not looking into this yet. Busy week. I'll see if I can get someone on my team to help look at this. tomorrow/early next week. :)

@jacobq
Copy link
Member

jacobq commented Nov 24, 2020

@Gamma169 @lsmun I released v0.6.0. Please give it a try and let me know if you run into anything. Also, if you'd like to take a shot at updating this to match Octane conventions or eliminating the observers or even just going through some of the deprecations I would appreciate that very much. (Of course, if you're too busy with other projects I totally get it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants